Open
Conversation
|
💔 -1 overall
This message was automatically generated. |
Aggarwal-Raghav
force-pushed
the
optimize_pom
branch
from
3244794 to
b1f2f53
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Aggarwal-Raghav
force-pushed
the
optimize_pom
branch
from
bf8eadb to
260a241
Compare
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
CC @abstractdog , can you plese review and advise on this. I believe we can upgrade the apache parent pom to 37 and cleanup some bits? Regarding memory increaese in surefire and checkstyle was done due to Memory issues observed in run 3rd run. It might be flaky!! |
Aggarwal-Raghav
commented
Mar 7, 2026
| <plugin> | ||
| <groupId>com.github.spotbugs</groupId> | ||
| <artifactId>spotbugs-maven-plugin</artifactId> | ||
| <configuration> |
Contributor
Author
There was a problem hiding this comment.
As the phase was not mentioned, this plugin is not running in default phase i.e. when we run mvn clean install. We have separate profile for it and its kept in pluginManagement
Aggarwal-Raghav
commented
Mar 7, 2026
| <rules> | ||
| <requireMavenVersion> | ||
| <version>[3.6.3,)</version> | ||
| <version>[3.8.7,)</version> |
Contributor
Author
There was a problem hiding this comment.
we can upgrade maven version dockerfile as an alternate as well to 3.9.0 or above
Aggarwal-Raghav
commented
Mar 7, 2026
| <artifactId>checkstyle</artifactId> | ||
| <version>${checkstyle.version}</version> | ||
| <groupId>org.codehaus.plexus</groupId> | ||
| <artifactId>plexus-velocity</artifactId> |
Contributor
Author
There was a problem hiding this comment.
plexus issue was observed in checkstyle as well. please check CI run 3
Aggarwal-Raghav
commented
Mar 7, 2026
| </build> | ||
| </profile> | ||
| <profile> | ||
| <id>clover</id> |
Contributor
Author
There was a problem hiding this comment.
very old profile 2015 and i don't think its of any use.
Contributor
There was a problem hiding this comment.
I can see that not only clover profile is removed here, but others too, below, like sources, javadoc
I cannot recall what clover profile is for, but I would encourage you the separate this change from an apache project upgrade to keep patches clean, so on a separate ticket, the profile removal can be clearly communicated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.