Decouple recursive var in CacheVC #12771
Merged
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bneradt
approved these changes
Dec 30, 2025
Contributor
bneradt
left a comment
bneradt
left a comment
There was a problem hiding this comment.
Looks good.
Just to check: I don't see read_recursive being initialized. I assume read_recursive is initialized by some memset(0) call somewhere along with the other members?
Contributor
Author
|
memset is called CacheVC() initialization in CacheVC.cc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
06a99bb causes a leak of CacheVConnection objects.
CacheVC::recursivealready used for user callback do_io_read/do_io_write/do_io_close/calluser/callcont and die() is only called if value is 0Seems like using same value for
CacheVC::openReadStartEarliestrecursive checks can increase above value and skips the die() call. Decoupling for different use cases