Fix DbgCtl use-after-free shutdown crash via leaky singleton #12777
+315
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bneradt
force-pushed
the
fix_centos_dbg_ctl_destruction_crash
branch
5 times, most recently
from
e61d46f to
c2b38b0
Compare
The DbgCtl registry was experiencing use-after-free crashes during program shutdown, particularly visible in CI regression tests. The root cause was the undefined destruction order of static objects in C++. Problem: - DbgCtl objects can be static or thread-local with lifetimes spanning program execution - When one compilation unit's DbgCtl destructs and triggers registry cleanup, other compilation units may still have DbgCtl objects with pointers into that registry - Thread exit order is also unpredictable, causing similar issues when thread-local DbgCtl objects destruct This implements the "leaky singleton" pattern where the registry is: - Created on first use - Never destroyed (destructor is now = default) - Memory (~20KB) reclaimed by OS at process exit Fixes: apache#12776
bneradt
force-pushed
the
fix_centos_dbg_ctl_destruction_crash
branch
from
c2b38b0 to
0399044
Compare
Contributor
Author
|
[approve ci fedora] |
bneradt
force-pushed
the
fix_centos_dbg_ctl_destruction_crash
branch
8 times, most recently
from
6e87b0c to
786bd8b
Compare
Contributor
Author
|
[approve ci fedora] |
bneradt
force-pushed
the
fix_centos_dbg_ctl_destruction_crash
branch
6 times, most recently
from
2ab9d48 to
ac1ccb5
Compare
bneradt
force-pushed
the
fix_centos_dbg_ctl_destruction_crash
branch
from
ac1ccb5 to
861f946
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DbgCtl registry was experiencing use-after-free crashes during program shutdown, particularly visible in CI regression tests. The root cause was the undefined destruction order of static objects in C++.
Problem:
This implements the "leaky singleton" pattern where the registry is:
Fixes: #12776