Skip to content

Fix HTTP/3 crash in HQTransaction::_signal_event #13093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bneradt wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −3
Open

Fix HTTP/3 crash in HQTransaction::_signal_event #13093

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/proxy/http3/Http3Transaction.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,15 +353,17 @@ HQTransaction::_close_write_complete_event(Event *e)
}

void
HQTransaction::_signal_event(int event, Event *edata)
HQTransaction::_signal_event(int event, Event * /* edata ATS_UNUSED */)
{
// HttpSM::main_handler expects a VIO* as the event data for VC events so it
// can locate the vc_table entry.
if (this->_write_vio.cont) {
SCOPED_MUTEX_LOCK(lock, this->_write_vio.mutex, this_ethread());
this->_write_vio.cont->handleEvent(event, edata);
this->_write_vio.cont->handleEvent(event, &this->_write_vio);
}
if (this->_read_vio.cont && this->_read_vio.cont != this->_write_vio.cont) {
SCOPED_MUTEX_LOCK(lock, this->_read_vio.mutex, this_ethread());
this->_read_vio.cont->handleEvent(event, edata);
this->_read_vio.cont->handleEvent(event, &this->_read_vio);
Comment on lines +362 to +366
Copy link
Copy Markdown
Contributor Author

@bneradt bneradt Apr 18, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you look at src/proxy/http2/Http2Stream.cc, everywhere where handleEvent is called, we pass a vio, not edata. This seems to confirm what Claude did here. And, as mentioned in the description, I no longer see these crashes anymore on docs with this change.

}
}

Expand Down