[REFACTOR][CI] Modernize Python dependency management with uv#18812
[REFACTOR][CI] Modernize Python dependency management with uv#18812mshr-h wants to merge 3 commits intoapache:mainfrom
Conversation
Summary of ChangesHello @mshr-h, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the project's Python dependency management by adopting Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request is a significant and welcome refactoring to modernize Python dependency management by replacing pip, conda, and poetry with uv. The changes are consistently applied across Dockerfiles, installation scripts, and documentation, leading to a much simpler and more maintainable CI setup. The simplification of the lockfile generation process is particularly noteworthy. I have one minor suggestion regarding documentation formatting. Overall, this is an excellent improvement.
docs/README.md
Outdated
| 'uv pip install --quiet tlcpack-sphinx-addon==0.2.1 && uv pip freeze' > frozen-requirements.txt | ||
|
|
||
| pip install -r frozen-requirements.txt | ||
| uv pip install -r frozen-requirements.txt |
There was a problem hiding this comment.
d4236c7 to
a9e418f
Compare
69a7445 to
18cd3f3
Compare
18cd3f3 to
dd7a1d2
Compare
guan404ming
left a comment
There was a problem hiding this comment.
Thanks, this is really a big improvement for dev experience.
| cython \ | ||
| mypy \ | ||
| uv pip install --upgrade \ | ||
| "Pygments~=2.19" \ |
There was a problem hiding this comment.
I have a dumb question, how do we get the the deps pins (e.g., Pygments/cloudpickle/cython/mypy/pytest/requests/scipy/Jinja2/ml_dtypes, etc.) here?
This PR modernizes Python tooling in CI by migrating Python interpreter installation, venv creation and package installation to uv.