[Relax] Make ShapeType ndim parameter mandatory

[guan404ming]

Why

Forces callers to be explicit about whether they want unknown ndim (-1) or a specific value. Prevents accidentally creating an unknown-ndim ShapeType when the caller intended to pass a concrete dimension, catching bugs at the call site rather than silently propagating unknown shapes.

How

• Remove default ndim from C++ and Python ShapeType constructors
• Update tests

[gemini-code-assist]

Summary of Changes

Hello @guan404ming, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enforces explicit ndim parameter passing for ShapeType constructors in both C++ and Python. This change aims to prevent unintended creation of ShapeType instances with unknown dimensions by requiring callers to specify ndim, thereby improving type safety and catching potential bugs earlier in the development cycle.

Highlights

• C++ ShapeType Constructor Update: The ndim parameter in the ShapeType constructor in include/tvm/relax/type.h no longer has a default value, making it a mandatory argument.
• Python ShapeType Constructor Update: The ndim parameter in the ShapeType constructor in python/tvm/relax/ty.py no longer has a default value, making it a mandatory argument.
• Test Case Adjustments: Existing test cases in test_ast_printer.py and test_struct_info.py were updated to explicitly pass the ndim argument when creating ShapeType instances, aligning with the new mandatory parameter.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• include/tvm/relax/type.h
  • Removed the default value for the ndim parameter in the ShapeType constructor.
• python/tvm/relax/ty.py
  • Removed the default value for the ndim parameter in the ShapeType constructor.
• tests/python/relax/test_ast_printer.py
  • Updated ShapeType instantiations to explicitly provide the ndim argument.
  • Modified TupleType creation to explicitly pass ndim=-1 to ShapeType.
• tests/python/relax/test_struct_info.py
  • Adjusted ShapeType instantiations to explicitly pass ndim=-1.

Activity

• No specific activity (comments, reviews, or progress updates) was provided in the context for this pull request.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request successfully makes the ndim parameter mandatory for the ShapeType constructor in both C++ and Python. This is a positive change that prevents accidental creation of unknown-rank shapes and improves code clarity. All relevant tests have been updated to reflect this change. I have one minor suggestion regarding the Python docstring to ensure it remains consistent with the updated signature.

[gemini-code-assist]

The ndim parameter is now mandatory in the constructor. However, the class docstring (at line 34, just above this hunk) still describes ndim as Optional[int]. Please update the docstring to int to maintain consistency with the implementation.

[guan404ming]

cc @tlopex @mshr-h

[guan404ming]

Thanks.