Repository navigation
[REFACTOR] Simplify TIRx CMake and package installation - #20751
Merged
Merged
Conversation
Scope compilation policy and thread-pool dependencies to TIRx targets, including their object libraries. Keep LLVM signature detection independent of parent compilation defaults. Use typed native option declarations, explicit module includes, shared-script patterns, documented install sections, and minimal parent exports.
Register package-owned payloads in standalone and embedded builds, and select the fixed component for each wheel. Keep TIRx installation in its source directory and TVM runtime extensions in the parent package.
tqchen
changed the title
spectrometerHBH
approved these changes
Oct 15, 2026
Seven-Streams
approved these changes
Oct 15, 2026
spectrometerHBH
approved these changes
Oct 15, 2026
Seven-Streams
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Give TVM and TIRx fixed install components so each package owns its headers, libraries, and support files in standalone and embedded builds. Each wheel selects its package component, and the parent no longer duplicates TIRx installation rules.
Scope TIRx compilation policy to its core and backend object/library targets, preserving embedding-project and bundled-FFI settings. Attach thread-pool requirements directly to runtime targets, retain GNU and Intel OpenMP selection, and isolate LLVM signature detection from parent compilation defaults.
Use typed native option declarations, explicit module includes, a shared-script source pattern, documented installation sections, and only the parent exports with consumers. Keep the installed package's shared-library interface and explicit FFI linkage.