[ZEPPELIN-6527] Fix flaky run-e2e-tests-in-zeppelin-web CI job (searchBlock Protractor timing)#5295
Open
miinhho wants to merge 4 commits into
Open
[ZEPPELIN-6527] Fix flaky run-e2e-tests-in-zeppelin-web CI job (searchBlock Protractor timing)#5295miinhho wants to merge 4 commits into
miinhho wants to merge 4 commits into
Conversation
Move the active classic zeppelin-web e2e coverage from Protractor to the existing Playwright harness. Add a classic Playwright project for the legacy /classic UI, port the active home and search block checks, and remove the obsolete Protractor/webdriver-manager entry points from zeppelin-web. Also update the frontend CI job to build the classic UI and run the migrated checks through zeppelin-web-angular's Playwright e2e flow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR removes the flaky classic
zeppelin-webProtractor e2e job by moving its remaining active coverage to the existing Playwright e2e workflow.The old
run-e2e-tests-in-zeppelin-webjob depended on Protractor, webdriver-manager, and a pinned ChromeDriver 2.35, and had been failing intermittently in the classic search/replace tests due to AngularJS/Ace synchronization timing.Since that stack is end-of-life and cannot be reasonably modernized in place, this PR ports the 10 active checks from
home.spec.jsandsearchBlock.spec.jsto Playwright, pointed at the classic/classicUI.The migrated tests keep the existing classic UI coverage for the home page, interpreter permission save flow, search shortcut, match counters, replace, and replace-all behavior. After that coverage is available in Playwright, the obsolete Protractor config, scripts, dependencies, and CI job are removed.
What type of PR is it?
Improvement
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-6527
How should this be tested?
For the Maven/CI path:
./mvnw clean install -DskipTests -am -pl python,zeppelin-jupyter-interpreter,zeppelin-web,zeppelin-web-angular -Pweb-classic xvfb-run --auto-servernum --server-args="-screen 0 1024x768x24" ./mvnw verify -pl zeppelin-web-angular -Pweb-e2eQuestions:
zeppelin-web/README.mdto reflect migrated classic web e2e test