[ZEPPELIN-6496] Replace BigQuery polling stdout output with SLF4J log…#5298
Open
celinayk wants to merge 1 commit into
Open
[ZEPPELIN-6496] Replace BigQuery polling stdout output with SLF4J log…#5298celinayk wants to merge 1 commit into
celinayk wants to merge 1 commit into
Conversation
ParkGyeongTae
approved these changes
Jul 13, 2026
ParkGyeongTae
left a comment
Member
There was a problem hiding this comment.
LGTM. The change correctly replaces the System.out.println in pollJob()
with LOGGER.info(...), which is already declared in the class.
Using SLF4J parameterized logging ({}) is a small additional improvement
over the original string concatenation — it avoids unnecessary string
construction when the INFO level is disabled.
Verified:
- No remaining
System.out/System.errcalls in thebigquerypackage. - Polling behavior (while loop,
Thread.sleep, returnedJob) is unchanged.
Nit: The PR title appears to be truncated — could you update it to
[ZEPPELIN-6496] Replace BigQuery polling stdout output with SLF4J logging?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
BigQueryInterpreter.pollJob(...)printed job polling status directly to standard output viaSystem.out.println(...), bypassing Zeppelin's SLF4J/Log4j2 loggingconfiguration, log levels, and appenders. This made diagnostics noisy and hard to route in server/interpreter deployments. This PR replaces the direct stdout call with a
structured SLF4J logger call.
What type of PR is it?
Improvement
Todos
System.out.println(...)inpollJob(...)withLOGGER.info(...)What is the Jira issue?
ZEPPELIN-6496
How should this be tested?
rg -n "System\.out\.println|System\.err\.println" bigquery/src/main/java/org/apache/zeppelin/bigqueryreturns no results./mvnw test -pl bigquerycompiles/builds successfullyScreenshots (if appropriate)
N/A
Questions: