feat(openapi): implement ResetInterface in OpenApiFactory#7922
Open
KevinMartinsDev wants to merge 2 commits intoapi-platform:mainfrom
Open
feat(openapi): implement ResetInterface in OpenApiFactory#7922KevinMartinsDev wants to merge 2 commits intoapi-platform:mainfrom
KevinMartinsDev wants to merge 2 commits intoapi-platform:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is the fourth part of the worker mode compatibility audit (see #7918). It implements
ResetInterfaceinOpenApiFactoryto handle internal state persistence.The Issue
OpenApiFactoryis a singleton service that maintains two types of internal state:RouteCollectionis stored in a private property.$localErrorResourceCache) that stores resolved error resources to avoid redundant processing.In persistent memory environments like FrankenPHP:
RouteCollectionuntil the worker restarts.The Solution
By implementing
Symfony\Contracts\Service\ResetInterface, we ensure that:$routeCollectionis reset tonull.$localErrorResourceCacheis cleared (reset to[]).This happens automatically after each request in worker mode, ensuring that the next request starts with fresh metadata and a clean memory footprint.