Skip to content

test: assert rating as a json number across json-streamer versions #8463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soyuka merged 1 commit into from
Aug 16, 2026
+8 −4
Merged

test: assert rating as a json number across json-streamer versions #8463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions tests/Functional/JsonStreamerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,9 @@ public function testJsonStreamerJsonLd(): void
$r = self::createClient()->request('GET', '/json_stream_resources/1', ['headers' => ['accept' => 'application/ld+json']]);
$res = json_decode($r->getBrowserKitResponse()->getContent(), true);
$this->assertIsInt($res['views']);
$this->assertIsFloat($res['rating']);
// json-streamer only encodes with JSON_PRESERVE_ZERO_FRACTION since 8.1.4, so an integral
// float decodes as int on lower versions
$this->assertTrue(\is_int($res['rating']) || \is_float($res['rating']));
$this->assertIsBool($res['isFeatured']);
$this->assertIsString($res['price']);
$this->assertEquals('/json_stream_resources/1', $res['@id']);
Expand Down Expand Up @@ -170,7 +172,9 @@ public function testJsonStreamerJson(): void
$r = self::createClient()->request('GET', '/json_stream_resources/1', ['headers' => ['accept' => 'application/json']]);
$res = json_decode($r->getBrowserKitResponse()->getContent(), true);
$this->assertIsInt($res['views']);
$this->assertIsFloat($res['rating']);
// json-streamer only encodes with JSON_PRESERVE_ZERO_FRACTION since 8.1.4, so an integral
// float decodes as int on lower versions
$this->assertTrue(\is_int($res['rating']) || \is_float($res['rating']));
$this->assertIsBool($res['isFeatured']);
$this->assertIsString($res['price']);
$this->assertArrayNotHasKey('@id', $res);
Expand Down Expand Up @@ -227,7 +231,7 @@ public function testJsonStreamerWriteJsonLd(): void
$this->assertResponseIsSuccessful();
$this->assertSame('asd', $res['title']);
$this->assertSame(0, $res['views']);
$this->assertSame(0.0, $res['rating']);
$this->assertEquals(0, $res['rating']);
$this->assertFalse($res['isFeatured']);
$this->assertContains($res['price'], ['0', '0.00']); // Depends on DB
$this->assertStringStartsWith('/json_stream_resources/', $res['@id']);
Expand Down Expand Up @@ -276,7 +280,7 @@ public function testJsonStreamerWriteJson(): void
$this->assertResponseIsSuccessful();
$this->assertSame('asd', $res['title']);
$this->assertSame(0, $res['views']);
$this->assertSame(0.0, $res['rating']);
$this->assertEquals(0, $res['rating']);
$this->assertFalse($res['isFeatured']);
$this->assertContains($res['price'], ['0', '0.00']); // Depends on DB
$this->assertArrayNotHasKey('@id', $res);
Expand Down
Loading