docs: align AISIX product terminology - #894
Merged
Merged
Conversation
kayx23
marked this pull request as ready for review
August 5, 2026 07:48
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
crates/aisix-core/src/models/guardrail.rs (1)
96-98: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winRemove the AWS SDK implementation detail from the public model description.
This comment is rendered as public Admin API documentation. Describe the gateway behavior instead of naming the AWS SDK provider type.
- /// and is not logged. The gateway passes it to the - /// AWS SDK's static credentials provider. + /// and is not logged. The gateway uses it to authenticate + /// requests to Amazon Bedrock.As per coding guidelines, comments in
crates/aisix-core/src/models/**/*.rsare public API reference text and must avoid internal shorthand.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@crates/aisix-core/src/models/guardrail.rs` around lines 96 - 98, Update the public model documentation near the decrypted credential field to describe the gateway’s behavior without mentioning the AWS SDK or its static credentials provider. Preserve the statements that plaintext is held only in memory and is not logged.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Dockerfile`:
- Around line 106-108: Update the comments at Dockerfile lines 106-108 and
config.managed.yaml line 1 to distinguish the products: refer to the data-plane
components as AISIX AI Gateway instances and state that they connect to or use
managed-mode configuration for AISIX Cloud. No other behavior changes are
needed.
In `@RELEASING.md`:
- Around line 3-6: Update the opening sentence in the release instructions to
establish the full product name as “AISIX AI Gateway,” while preserving “AISIX
gateway” for subsequent references in the document.
In `@schemas/resources/guardrail.schema.json`:
- Line 23: Update the description for the affected schema property to use public
gateway behavior terms instead of internal implementation details such as
“projection” and the AWS SDK’s static credentials provider. Preserve the
existing security guarantees about in-memory plaintext handling and non-logging
while describing the gateway’s externally observable credential-passing
behavior.
---
Nitpick comments:
In `@crates/aisix-core/src/models/guardrail.rs`:
- Around line 96-98: Update the public model documentation near the decrypted
credential field to describe the gateway’s behavior without mentioning the AWS
SDK or its static credentials provider. Preserve the statements that plaintext
is held only in memory and is not logged.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: e2251f42-38a3-4c7e-a56a-ab6625737ca1
📒 Files selected for processing (17)
CLAUDE.mdDockerfileREADME.mdRELEASING.mdROADMAP.mdconfig.example.yamlconfig.managed.yamlcrates/aisix-admin/src/openapi.rscrates/aisix-core/src/config.rscrates/aisix-core/src/models/guardrail.rscrates/aisix-core/src/models/observability_exporter.rscrates/aisix-core/src/models/provider_key.rscrates/aisix-server/src/export/mod.rsdocker/entrypoint.shschemas/resources/guardrail.schema.jsonschemas/resources/observability_exporter.schema.jsonschemas/resources/provider_key.schema.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aisix.clouddomainsWhy
Public and maintainer-facing surfaces mixed product names, runtime modes, and architecture roles. In particular, the open-source gateway was sometimes described unconditionally as a data plane, even though that role applies only when the gateway is connected to AISIX Cloud.
This PR aligns the repository with the finalized terminology used in the public AISIX documentation without changing runtime behavior or compatibility identifiers.
Remaining work and engineering input
For planning purposes, this PR covers approximately 85% of the actionable terminology findings identified in the
api7/aisixaudit. The estimate is based on six direct workstreams—agent guidance, product positioning, release and roadmap prose, configuration and container guidance, Admin API and CLI copy, and generated schemas—versus one engineering-dependent internal-architecture workstream. It is not based on raw string occurrences.The remaining approximately 15% is internal implementation commentary and test terminology that refers to historical concepts such as a “self-hosted CP,” “self-hosted etcd mode,” an
aisix.cloudtenant, or a “standalone gateway.” Some of those labels encode runtime and control-plane assumptions rather than product terminology. Gateway engineers should confirm the intended architectural meaning before they are rewritten. Valid uses that describe self-hosted upstream models or services should remain unchanged.Validation
cargo test -p aisix-admin openapi --lib— 22 passedcargo test -p aisix-admin openapi_uses_open_source_gateway_apikey_request_schema --libcargo test -p aisix-core managed_container_examples_use_supported_bootstrap_env --libcargo clippy -p aisix-core --lib --tests -- -D warningscargo run -p aisix-core --bin dump-schemash -n docker/entrypoint.shgit diff --checkSummary by CodeRabbit
Documentation
Tests