docs(e2e): record the readiness-gate rule for e2e specs - #898
Conversation
The invariant that makes a propagation gate sound lived only in one spec's comment, so a new spec repeated the race it prevents: gating on a model seeded mid-sequence while asserting on resources written after it. Test ordering masked it, since a later test in the same file already ran against a warm snapshot. tests/e2e/ had no scoped instructions file; add one carrying just this rule, at the narrowest scope that covers it.
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 39 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Comment |
1 participant
Follow-up to #897.
The invariant that makes a propagation gate sound — seeded resources arrive as etcd watch events in revision order, so waiting on resource N proves only that everything up to N landed — lived only in
tag-routing-e2e.test.ts's comment. #897 duly repeated the race it prevents: the new spec gated on a model seeded mid-sequence and then asserted on resources written after it. It passed anyway, because a later test in the same file runs against a snapshot the earlier test already warmed, which is exactly what makes this class hard to notice.tests/e2e/had no scoped instructions file, so the rule had nowhere to live where the next spec author would see it. Adding one with just this rule, plus the two shapes a gate must not take: a request that exercises the behavior under test (a regression then reads as a 30s timeout instead of an assertion diff), and a catch-all that swallows every error (a401before key propagation is normal, but an upstream or transport failure should surface as itself).No code or test changes.