Skip to content

chore: move to pnpm from yarn #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
vladfrangu wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

chore: move to pnpm from yarn #1068

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9d40293
chore: pnpm attempt
vladfrangu Apr 1, 2026
4ad7e92
fix: shamefully hoist everything
vladfrangu Apr 1, 2026
eed98d2
fix: ci for tests
vladfrangu Apr 1, 2026
a47f95b
chore: try to split up website build
vladfrangu Apr 8, 2026
1a679f8
chore: fmt
vladfrangu Apr 8, 2026
8dfc5c6
fix: website and eslint
vladfrangu Apr 9, 2026
de393eb
chore: update lint-staged to include jsx/tsx
vladfrangu Apr 9, 2026
2d1315e
feat: setup minimum release age
vladfrangu Apr 9, 2026
87fe890
feat: formatting and renovate 1day too
vladfrangu Apr 9, 2026
aef939c
fix: test on node 20
vladfrangu Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,7 @@ indent_size = 4

[*.yaml]
indent_size = 4

[*.json]
indent_size = 4
indent_style = tab
42 changes: 42 additions & 0 deletions .github/actions/pnpm-install/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
name: "pnpm install"
description: "Run pnpm install with cache enabled"
runs:
using: "composite"
steps:
- name: Set up swap space
if: runner.os == 'Linux'
uses: pierotofy/set-swap-space@v1.0
with:
swap-size-gb: 10

- uses: pnpm/action-setup@v4.1.0
name: Install pnpm
with:
run_install: false

- name: Expose pnpm config(s) through "$GITHUB_OUTPUT"
id: pnpm-config
shell: bash
run: |
echo "STORE_PATH=$(pnpm store path)" >> $GITHUB_OUTPUT

- name: Cache rotation keys
id: cache-rotation
shell: bash
run: |
echo "YEAR_MONTH=$(/bin/date -u "+%Y%m")" >> $GITHUB_OUTPUT

- uses: actions/cache@v4
name: Setup pnpm cache
with:
path: ${{ steps.pnpm-config.outputs.STORE_PATH }}
key: ${{ runner.os }}-pnpm-store-cache-${{ steps.cache-rotation.outputs.YEAR_MONTH }}-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-pnpm-store-cache-${{ steps.cache-rotation.outputs.YEAR_MONTH }}-

- name: Install dependencies
shell: bash
run: |
pnpm install --frozen-lockfile --prefer-offline --loglevel error
env:
HUSKY: "0"
140 changes: 24 additions & 116 deletions .github/workflows/check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,26 +31,15 @@ jobs:
uses: actions/setup-node@v6
with:
node-version: ${{ env.LATEST_NODE_VERSION }}
package-manager-cache: false

- name: Enable corepack
run: |
corepack enable
corepack prepare yarn@stable --activate

- name: Activate cache for yarn
uses: actions/setup-node@v6
with:
cache: yarn

- name: Install Dependencies
run: yarn
- name: Install pnpm and dependencies
uses: ./.github/actions/pnpm-install

- name: Run TSC
run: yarn build
run: pnpm run build

- name: Ensure the reference documentation builds
run: yarn update-docs
run: pnpm run update-docs

lint:
if: ${{ !contains(github.event.head_commit.message, '[skip ci]') }}
Expand All @@ -66,26 +55,15 @@ jobs:
uses: actions/setup-node@v6
with:
node-version: ${{ env.LATEST_NODE_VERSION }}
package-manager-cache: false

- name: Enable corepack
run: |
corepack enable
corepack prepare yarn@stable --activate

- name: Activate cache for yarn
uses: actions/setup-node@v6
with:
cache: yarn

- name: Install Dependencies
run: yarn
- name: Install pnpm and dependencies
uses: ./.github/actions/pnpm-install

- name: Run lint checks
run: yarn lint
run: pnpm run lint

- name: Run format checks
run: yarn format
run: pnpm run format

test_local:
if: ${{ !contains(github.event.head_commit.message, '[skip ci]') }}
Expand Down Expand Up @@ -113,34 +91,18 @@ jobs:
uses: actions/setup-node@v6
with:
node-version: ${{ matrix.node-version }}
package-manager-cache: false

- name: Enable corepack
run: |
corepack enable
corepack prepare yarn@stable --activate

- name: Activate cache for npm
uses: actions/setup-node@v6
with:
cache: npm

- name: Activate cache for yarn
uses: actions/setup-node@v6
with:
cache: yarn
- name: Install pnpm and dependencies
uses: ./.github/actions/pnpm-install

- name: Setup Python 3.12 (Windows)
if: ${{ matrix.os == 'windows-2025' }}
uses: actions/setup-python@v6
with:
python-version: 3.14

- name: Install Dependencies
run: yarn

- name: Run local tests
run: yarn test:local
run: pnpm run test:local

test_api:
if: ${{ !contains(github.event.head_commit.message, '[skip ci]') }}
Expand All @@ -162,30 +124,14 @@ jobs:
uses: actions/setup-node@v6
with:
node-version: ${{ env.LATEST_NODE_VERSION }}
package-manager-cache: false

- name: Enable corepack
run: |
corepack enable
corepack prepare yarn@stable --activate

- name: Activate cache for npm
uses: actions/setup-node@v6
with:
cache: npm

- name: Activate cache for yarn
uses: actions/setup-node@v6
with:
cache: yarn

- name: Install Dependencies
run: yarn
- name: Install pnpm and dependencies
uses: ./.github/actions/pnpm-install

- name: Run API tests
env:
TEST_USER_TOKEN: ${{ secrets.APIFY_TEST_USER_API_TOKEN }}
run: yarn test:api
run: pnpm run test:api

test_python_support:
if: ${{ !contains(github.event.head_commit.message, '[skip ci]') }}
Expand Down Expand Up @@ -213,25 +159,9 @@ jobs:
uses: actions/setup-node@v6
with:
node-version: ${{ env.LATEST_NODE_VERSION }}
package-manager-cache: false

- name: Enable corepack
run: |
corepack enable
corepack prepare yarn@stable --activate

- name: Activate cache for npm
uses: actions/setup-node@v6
with:
cache: npm

- name: Activate cache for yarn
uses: actions/setup-node@v6
with:
cache: yarn

- name: Install Dependencies
run: yarn
- name: Install pnpm and dependencies
uses: ./.github/actions/pnpm-install

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v6
Expand All @@ -241,7 +171,7 @@ jobs:
- name: Run Python tests
env:
TEST_USER_TOKEN: ${{ secrets.APIFY_TEST_USER_API_TOKEN }}
run: yarn test:python
run: pnpm run test:python

docs:
if: ${{ !contains(github.event.head_commit.message, '[skip ci]') }}
Expand All @@ -257,26 +187,15 @@ jobs:
uses: actions/setup-node@v6
with:
node-version: ${{ env.LATEST_NODE_VERSION }}
package-manager-cache: false

- name: Enable corepack
run: |
corepack enable
corepack prepare yarn@stable --activate

- name: Activate cache for yarn
uses: actions/setup-node@v6
with:
cache: yarn

- name: Install Dependencies
run: yarn
- name: Install pnpm and dependencies
uses: ./.github/actions/pnpm-install

- name: Build & deploy docs
run: |
cd website
yarn
yarn build
pnpm install
pnpm run build

build_bundles:
if: ${{ !contains(github.event.head_commit.message, '[skip ci]') }}
Expand Down Expand Up @@ -305,20 +224,9 @@ jobs:
uses: actions/setup-node@v6
with:
node-version: ${{ env.LATEST_NODE_VERSION }}
package-manager-cache: false

- name: Enable corepack
run: |
corepack enable
corepack prepare yarn@stable --activate

- name: Activate cache for yarn
uses: actions/setup-node@v6
with:
cache: yarn

- name: Install Dependencies
run: yarn
- name: Install pnpm and dependencies
uses: ./.github/actions/pnpm-install

- name: Install bun
uses: oven-sh/setup-bun@v2
Expand Down Expand Up @@ -351,7 +259,7 @@ jobs:
bun build --compile --target=bun-windows-x64-baseline --outfile test index.ts

- name: Build Bundles
run: yarn insert-cli-metadata && yarn build-bundles
run: pnpm run insert-cli-metadata && pnpm run build-bundles

- name: Upload Bundles
uses: actions/upload-artifact@v7
Expand Down
17 changes: 3 additions & 14 deletions .github/workflows/cucumber.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,23 +33,12 @@ jobs:
uses: actions/setup-node@v6
with:
node-version: ${{ matrix.node-version }}
package-manager-cache: false

- name: Enable corepack
run: |
corepack enable
corepack prepare yarn@stable --activate

- name: Activate cache for yarn
uses: actions/setup-node@v6
with:
cache: yarn

- name: Install Dependencies
run: yarn
- name: Install pnpm and dependencies
uses: ./.github/actions/pnpm-install

- name: Run Cucumber tests
env:
APIFY_CLI_DISABLE_TELEMETRY: 1
TEST_USER_TOKEN: ${{ secrets.APIFY_TEST_USER_API_TOKEN }}
run: yarn test:cucumber
run: pnpm run test:cucumber
24 changes: 7 additions & 17 deletions .github/workflows/docs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,32 +29,22 @@ jobs:
uses: actions/setup-node@v6
with:
node-version: 24
package-manager-cache: false

- name: Enable corepack
run: |
corepack enable
corepack prepare yarn@stable --activate

- name: Activate cache for yarn
uses: actions/setup-node@v6
with:
cache: yarn
- name: Install pnpm and dependencies
uses: ./.github/actions/pnpm-install

- name: Build docs
run: |
# install project deps
yarn
# update next docs reference
yarn update-docs
pnpm run update-docs
# go to website dir
cd website
# install website deps
yarn
pnpm install
# install the latest theme version
yarn add @apify/docs-theme@latest
pnpm add @apify/docs-theme@latest
# build the docs
yarn build
pnpm run build
env:
SMARTLOOK_PROJECT_KEY: ${{ secrets.SMARTLOOK_DOCS_PROJECT_KEY }}
GIT_USER: "apify-service-account:${{ secrets.APIFY_SERVICE_ACCOUNT_GITHUB_TOKEN }}"
Expand All @@ -66,7 +56,7 @@ jobs:
uses: stefanzweifel/git-auto-commit-action@v7
with:
commit_message: "chore: Automatic theme updating workflow [skip ci]"
file_pattern: "website/package*.json website/yarn.lock"
file_pattern: "website/package*.json website/pnpm-lock.yaml"
commit_user_name: Apify Bot
commit_user_email: my-github-actions-bot@example.org
commit_author: Apify Bot <apify@apify.com>
Expand Down
Loading
Loading