feat: add repeatable --env flag to push (#734) - #1352
Open
MatousMarik wants to merge 2 commits into
Open
Conversation
MatousMarik
force-pushed
the
feat/push-env-flag-734
branch
4 times, most recently
from
August 25, 2026 18:31
348713b to
414f9dc
Compare
Flags.string({ multiple: true }) collects repeated flag values into a
string[] instead of rejecting the second occurrence. The parser already
registered every flag with multiple: true; the value was collapsed and
guarded in _parseFlags, which now keeps the array for flags tagged as
multi-value.
Passes environment variables in KEY=VALUE format directly to the Actor version, primarily for CI. The values are merged with environmentVariables from actor.json, with the CLI value winning on key conflicts. @secret references resolve the same way as in the file.
MatousMarik
force-pushed
the
feat/push-env-flag-734
branch
from
August 25, 2026 19:33
414f9dc to
60c5b8d
Compare
MatousMarik
marked this pull request as ready for review
August 26, 2026 08:21
MatousMarik
requested review from
DaveHanns,
l2ysho and
szaganek
as code owners
August 26, 2026 08:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes #734, stacked on #1346 (retarget to
masteras the stack merges — only the last two commits are new here).What
--env KEY=VALUEflag onapify push, primarily for passing build args / env vars in CI without touching actor.json or the Console.environmentVariablesfrom.actor/actor.json; on key conflict the--envvalue wins.@secretreferences resolve the same way as in the file (viaapify secrets add). Malformed values (noKEY=) fail fast with exit code 5 before anything is uploaded.Flags.string({ multiple: true })— multi-value string flags typed asstring[]. The parser already registered every flag withmultiple: trueand collapsed the array in_parseFlags; flags tagged multi-value now keep it. Includes the'strings'flag tag in type inference and both help renderers.choicesanddefaultare type-forbidden together withmultiple: true(unimplemented in parsing); The short-form-x=valueleading-=strip is applied per element and now fires only on genuine short-form usage (parseArgs reports the canonical long name intoken.namefor both forms, so detection usesrawName— previously--flag '=x'was also stripped); stdin (-) is disabled for multi-value flags instead of being silently broken.Resulting env var semantics
environmentVariablesin actor.json--env--env A=1vars.mdand the flag description){...}{}(empty object){...}--env ...Tests
KEY=VALUEparser (merge order,=in values, empty value, malformed entries, and__proto__as a key — the accumulator is null-prototype so it can't be swallowed).[api]tests: file + CLI vars merge with CLI winning;@secretrefs from both actor.json and--envland asisSecret: trueand never come back in plain text; platform vars preserved when the field is absent and cleared by an explicit{}(pins the table above). Full push API suite passes (17/17), plustest:local, lint, format, build.--envparses, malformed value exits 5.No new dependencies; no install-size impact.