fix: correct non-interactive error message mentioning --confirm/--no-confirm - #1358
Open
kuntal1461 wants to merge 1 commit into
Open
fix: correct non-interactive error message mentioning --confirm/--no-confirm#1358kuntal1461 wants to merge 1 commit into
kuntal1461 wants to merge 1 commit into
Conversation
…confirm Closes apify#1354. - stdinCheckWrapper default error referenced --confirm/--no-confirm flags that do not exist; replaced with a message pointing to --yes (the actual bypass flag used by all rm commands) - Added per-call errorMessageForStdin to the two migration prompts in useActorConfig where --yes is not applicable, giving an accurate "run in an interactive terminal" message instead - Added regression tests in test/local/lib/stdinCheckWrapper.test.ts that assert the old flag names no longer appear and --yes is mentioned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1354.
What changed and why
_stdinCheckWrapper.ts: Removed the deadConfirmFlag/NoConfirmFlagconstants and replaced the defaulterrorMessageForStdinwith a message that points to--yes— the flag that actually exists and bypasses confirmation prompts on allrmcommands.useActorConfig.ts: Added a per-callerrorMessageForStdinto both config-migration prompts. Those prompts cannot be bypassed via--yes(the flag is never propagated into the hook), so the message correctly tells users to run in an interactive terminal instead.test/local/lib/stdinCheckWrapper.test.ts: New regression tests (7) that assert--confirm/--no-confirmnever appear in the default error,--yesis mentioned, and all override-priority rules hold.Before / After
Before (any
rmcommand in CI without--yes):(those flags do not exist)
After:
Notes
pnpm run update-docsnot required.test:localare unrelated to this change (environment issue with Python 3.14 on the dev machine).