ci: Sort generated model classes alphabetically with topological ordering#727
Merged
ci: Sort generated model classes alphabetically with topological ordering#727
Conversation
…dering Add class sorting to postprocess_generated_models.py that orders class definitions alphabetically while respecting inheritance dependencies via topological sort. This makes regeneration from a reordered OpenAPI spec produce minimal diffs. Also makes add_docs_group_decorators idempotent. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
vdusek
added
adhoc
vdusek
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #727 +/- ##
==========================================
+ Coverage 95.28% 95.36% +0.07%
==========================================
Files 45 45
Lines 5114 5114
==========================================
+ Hits 4873 4877 +4
+ Misses 241 237 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pijukatel
reviewed
Apr 15, 2026
Contributor
Pijukatel
left a comment
Pijukatel
left a comment
There was a problem hiding this comment.
I would suggest adding a few test cases for the sorting. This functionality should not be hard to test.
Pijukatel
approved these changes
Apr 15, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions
bot
added
the
tested
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
postprocess_generated_models.py, so that regeneration from a reordered OpenAPI spec produces minimal diffs.add_docs_group_decoratorsidempotent so the script can be safely re-run._models.py.Note
🤖 Generated with Claude Code