refactor!: Use snake case for actors().list(sort_by=...)#736
Merged
Conversation
Change the sort_by Literal to pythonic snake_case values ('created_at',
'last_run_started_at') and translate them to the API's camelCase form
('createdAt', 'stats.lastRunStartedAt') inside the client.
vdusek
added
adhoc
github-actions
bot
added
the
tested
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #736 +/- ##
=======================================
Coverage 95.26% 95.27%
=======================================
Files 45 45
Lines 5115 5118 +3
=======================================
+ Hits 4873 4876 +3
Misses 242 242
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pijukatel
approved these changes
Apr 17, 2026
Contributor
Pijukatel
left a comment
Pijukatel
left a comment
There was a problem hiding this comment.
But this should be marked as breaking, right?
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
vdusek
changed the title
vdusek
changed the title
vdusek
changed the title
actors().list(sort_by=...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sort_byparameter ofActorCollectionClient(Async).list()from the camelCase API values ('createdAt','stats.lastRunStartedAt') to pythonic snake_case values ('created_at','last_run_started_at')._SORT_BY_TO_APImapping to translate to the API's expected form before dispatching the request.Closes #700.