Open
Conversation
The post-publish doc release job invokes manual_release_docs.yaml with a commit SHA, so actions/checkout leaves the repo in detached HEAD and the hand-rolled git push fails. Switch to EndBug/add-and-commit with new_branch set to the default branch, and apply the same fix to manual_version_docs.yaml where the same latent bug existed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #741 +/- ##
==========================================
- Coverage 95.38% 95.25% -0.14%
==========================================
Files 45 45
Lines 5118 5118
==========================================
- Hits 4882 4875 -7
- Misses 236 243 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
doc_release_post_publishjob inon_master.yamlinvokesmanual_release_docs.yamlwith a commit SHA asref, soactions/checkoutleaves the repo in a detached HEAD state. The hand-rolledCommit the updated package.json and lockfilestep then runsgit push, which fails withfatal: You are not currently on a branch.(see failing run). The push was also invoked unconditionally even when there was nothing to commit.Fix
EndBug/add-and-commit@v10(matchingmanual_version_docs.yaml).new_branch: ${{ github.event.repository.default_branch }}so the action creates/checks out a local default branch before committing. This is required because EndBug does not handle detached HEAD by itself — its default push isgit push origin --set-upstream(no refspec), which fails the same way.new_branchfix tomanual_version_docs.yaml, which has the identical latent bug (introduced in ci: Extract docs versioning and release into reusable workflows #728 but not yet exercised by a stable release).