feat(charging): Support the idempotency_key param in Actor.charge() - #1123
Merged
Merged
Conversation
Mantisus
changed the title
idempotency_key param in Actor.charge()
Mantisus
commented
Sep 11, 2026
Collaborator
Author
|
@barjin, Please take a look at the implementation. In the TS SDK, the |
barjin
reviewed
Sep 14, 2026
barjin
left a comment
barjin
left a comment
Member
There was a problem hiding this comment.
Thank you @Mantisus !
Good catch, we need this in JS SDK as well, otherwise the deduplicated charges will eventually desync the running total count. I opened an issue here.
Otherwise, I left a few ideas regarding the implementation ⬇️ Thanks again!
Collaborator
Author
|
@vdusek, could you recheck this, please? |
vdusek
approved these changes
Sep 24, 2026
Contributor
|
@barjin Do you want to recheck this? 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the
idempotency_keyparameter inActor.charge().Closes: #1122