You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Use ApifyStorageClient(request_queue_access='shared') for test_concurrent_processing_simulation. This is the expected usage for concurrent access. And fix the error in the test
The reason will be displayed to describe this comment to others. Learn more.
I have a feeling that this test was flaky for the shared client even before the single client was introduced. Could you stress test it a little locally since the CI is now not running integration tests on fork PRs?
The # Randomly reclaim some requests branch caused the worker to execute reclaim_request and immediately fetch_next_request, looping in this state. This was quite random, as it only reproduced if the worker took on 8 requests (a total of 20 requests for 3 workers).
The worker would only exit this state if, at some point in time, another worker managed to take on this request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
ApifyStorageClient(request_queue_access='shared')fortest_concurrent_processing_simulation. This is the expected usage for concurrent access. And fix the error in the testIssues
Closes: #529