test: replace fixed sleep with polling for RQ stats assertions#864
Merged
test: replace fixed sleep with polling for RQ stats assertions#864
Conversation
The Apify platform's request queue stats are eventually consistent and a fixed 10-second sleep was sometimes not enough for them to propagate, causing intermittent failures. Added a `poll_until_condition` helper that retries up to 60 s (in 5 s intervals) and updated all stats-checking assertions to use it. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #864 +/- ##
=======================================
Coverage 86.57% 86.57%
=======================================
Files 48 48
Lines 2920 2920
=======================================
Hits 2528 2528
Misses 392 392
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pijukatel
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
poll_until_condition()helper totests/integration/_utils.py— polls an async callable until a condition is met or a 60-second timeout expires (5-second intervals).await asyncio.sleep(10)+ single-fetch patterns in 7 request queue integration tests withpoll_until_condition, fixing intermittent failures where 10 s was not enough for Apify's eventually-consistent stats API to propagate.The following tests were intermittently failing in CI due to this timing issue:
test_request_queue_metadata_another_client[single]test_crawler_run_request_queue_variant_stats[Full rq client]test_request_queue_has_stats[shared]test_request_queue_deduplication_unprocessed_requests[shared]test_request_queue_deduplication_use_extended_unique_key[single]Failed CI runs that triggered this fix: