test: retry flaky webhook E2E test on platform-side timeouts#937
Open
vdusek wants to merge 3 commits into
Open
test: retry flaky webhook E2E test on platform-side timeouts#937vdusek wants to merge 3 commits into
vdusek wants to merge 3 commits into
Conversation
The server Actor blocks until the platform delivers the webhook fired by the client's ACTOR_RUN_SUCCEEDED event, so when delivery is delayed past the run timeout the run ends as TIMED-OUT. Add pytest-rerunfailures and mark test_actor_adds_webhook_and_receives_event with @pytest.mark.flaky(reruns=2) so this platform-side flake is retried rather than failing CI.
vdusek
added
adhoc
github-actions
Bot
added
the
tested
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #937 +/- ##
=======================================
Coverage 86.94% 86.94%
=======================================
Files 48 48
Lines 2942 2942
=======================================
Hits 2558 2558
Misses 384 384
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The E2E test
test_actor_adds_webhook_and_receives_eventis flaky. The server Actor blocks until the Apify platform delivers the webhook fired by the client Actor'sACTOR_RUN_SUCCEEDEDevent; when platform-side delivery is delayed past the server run's 600s timeout, the run ends asTIMED-OUTand the assertion fails. This has been observed on bothmaster(run 26950690902) and an unrelated docs PR (run 26959362332) on the same day, each burning the full timeout with no delivery.There is no test-logic root cause to fix — the latency is platform-side and outside the SDK's control. This adds
pytest-rerunfailuresand marks the test@pytest.mark.flaky(reruns=3), so a transient delivery hiccup is retried instead of failing CI. A comment on the test documents the failure mode.