Repository navigation
refactor!: remove legacy get-commits, get-latest-commit and get-changed-files - #228
Open
metalwarrior665 wants to merge 2 commits into
Open
metalwarrior665 wants to merge 2 commits into
metalwarrior665 wants to merge 2 commits into
Conversation
…ed-files get-affected-actors reports the same commits and changed files from one shared diff path. Dropping the three legacy commands removes getCommits, getChangedFiles, parseBaseCommit, the --base-commit/--source-branch/ --target-branch flags and the Config type, and lets resolveReleaseBaseCommit reuse findCommitSha. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016XtpQvEqmuEhj1cBAaUxML
metalwarrior665
marked this pull request as ready for review
November 3, 2026 14:58
metalwarrior665
requested review from
JuanGalilea and
ruocco-l
as code owners
November 3, 2026 14:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this makes sense, users can use
get-affected-actorsto get changedFiles too.AI
get-affected-actors(#204) now computes commits, changed files and changelog in one place from a single diff path. The three older commands (get-commits,get-latest-commit,get-changed-files) are documented as "kept for older workflows", but no workflow in this repo uses them. They still carry a second, parallel git model:getCommits, which has its own rerun and base-commit heuristics and duplicates whatsincedoes inget-affected-actors.getChangedFiles, which isgetChangedFilesBetweenwith a~hack.parseBaseCommit, with the "SHA or Commit JSON" overload that only existed to pipeget-latest-commitoutput back in.--source-branch,--target-branchand--base-commitflags, thegitRangeOptionsgroup and theConfigtype.#218 left these out on purpose and said the call belongs to the maintainers. This PR is that proposal.
What
resolveReleaseBaseCommitnow validates the SHA inline and reusesfindCommitSha, instead of a second copy of the "rev-parseexit code 1 means missing" handling.docs/cli.md. CONTRIBUTING's CLI example now usesget-affected-actors --base master.logging.test.ts. It compiled the whole project withtsc(the cause of test: raise the Vitest hook timeout to 60s #227's timeout) just to check log levels throughget-commits. The same check is now two cases incli-bundle.test.tsthat runget-affected-actorsagainst the committed bundle.Breaking
Anyone who calls these three commands directly breaks. The
workflows-v0reusable workflows don't, so only external users scripting the CLI are affected. Since we're before v1, this is the cheapest time to drop them. Whether to do it is the open question for reviewers.Other ideas I considered and left out
Each overlaps an open PR, so it would conflict:
testandnotifycommands) and fix(test): clean up compiled CLI dir when build fails #224 (bundle-based CLI tests) already cover the build and reporting code.lib/gaps from issues (failsmodifier Feature request: Allow marking a test run as failing #159, standby without a task testStandbyActor cannot test multi-tenant standby actors #127) are features, not refactors.Checks
tsc, eslint, prettier, knip (the unused exports it lists were already on master) andnpm testpass: 31 files, 438 tests.Generated by Claude Code