Conversation
…ntly rate-limited domains
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A 429 from a domain throttled by
ThrottlingRequestManagerno longer counts as a failure. The request goes back to its queue and waits out the domain's backoff. The retry doesn't count towardsmax_request_retriesormax_session_rotations, the session isn't marked as bad, and the 429 doesn't reacherror_handlerorfailed_request_handler. Settingignore_http_error_status_codes={429}no longer passes such a response to the request handler.A domain that keeps rate-limiting every request no longer holds the crawl forever. The new
max_domain_stalloption onThrottlingRequestManager(15 minutes by default) sets how long that may last. The crawler still finishes every other domain first, thencrawler.run()raisesPersistentRateLimitError. The stalled domain's requests stay queued, so a later run can resume them.New errors (parity with Crawlee TS):
RequestThrottledError: the crawler raises it for a throttled 429 and defers the request.PersistentRateLimitError: raised fromcrawler.run()when a domain has stalled for longer thanmax_domain_stall.Issues
ThrottlingRequestManagerdoes not stop a 429 from retiring the session #2143Testing