Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
@seelink onStatus::CLIENT_CLOSED_REQUEST(499) points to https://httpstatuses.com/499. Every httpstatuses.com URL now returns a 301 to a web agency glossary (https://www.webfx.com/web-development/glossary/), so the rendered API docs at https://docs.aplus-framework.com/classes/Framework-HTTP-Status.html send readers there too. MDN has no page for 499, which is probably why this constant doesn't use an MDN link like most of the class.This PR points the link to https://httpstatuses.net/499/. That page covers where 499 comes from (nginx's
NGX_HTTP_CLIENT_CLOSED_REQUEST), when nginx logs it, and the gRPC CANCELLED to 499 mapping.I run httpstatuses.net. It isn't affiliated with httpstatuses.com. If you prefer a primary source, nginx defines 499 in https://github.com/nginx/nginx/blob/master/src/http/ngx_http_request.h, and I can switch the link to it.