Bump JUnit to JUnit 6+ - #279
Merged
Merged
Conversation
ferid333
reviewed
Aug 28, 2026
Comment on lines
+32
to
+35
| tasks.named('compileTestJava') { | ||
| sourceCompatibility = '17' | ||
| targetCompatibility = '17' | ||
| } |
There was a problem hiding this comment.
Hello, I have one question. Since JUnit 6 requires Java 17 at runtime, is configuring sourceCompatibility and targetCompatibility only for compileTestJava sufficient here? This ensures the test code is compiled for Java 17, but as I far as I know , it doesn't necessarily ensure that the tests are actually executed using Java 17. Should we configure the Java toolchain or test JVM to use Java 17 as well?
Collaborator
Author
There was a problem hiding this comment.
Java toolchain test VM is run on 17, 21, and 25 today, configured in the GitHub CI configuration
riyazpanjwani
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.