Skip to content

Fix null request bodies for PUT requests #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ferid333 wants to merge 1 commit into from
+19 −1
Closed

Fix null request bodies for PUT requests #281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/apple/itunes/storekit/client/BaseAppStoreServerAPIClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ protected <T> T makeHttpCall(String path, String method, Map<String, List<String
encodedBody = (byte[]) body;
} else if (body != null) {
encodedBody = objectMapper.writeValueAsString(body).getBytes(StandardCharsets.UTF_8);
} else if (method.equals("POST")) {
} else if (method.equals("POST") || method.equals("PUT")) {
encodedBody = new byte[] {};
} else {
encodedBody = null;
Expand Down
18 changes: 18 additions & 0 deletions src/test/java/com/apple/itunes/storekit/client/AppStoreServerAPIClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,6 +790,24 @@ public void testConfigureRealtimeURL() throws IOException, APIException {
client.configureRealtimeURL(realtimeUrlRequest);
}

@Test
public void testConfigureRealtimeURLWithNullBody() throws IOException, APIException {
AppStoreServerAPIClient client = getAppStoreServerAPIClient("", request -> {
Assertions.assertEquals("PUT", request.method());
Assertions.assertEquals("/inApps/v1/messaging/realtime/url", request.url().encodedPath());
RequestBody body = request.body();
Assertions.assertNotNull(body);
Assertions.assertEquals(expectedMediaType, body.contentType());
try {
Assertions.assertEquals(0, body.contentLength());
} catch (IOException e) {
throw new RuntimeException(e);
}
});

client.configureRealtimeURL(null);
}

@Test
public void testDeleteRealtimeURL() throws IOException, APIException {
AppStoreServerAPIClient client = getAppStoreServerAPIClient("", request -> {
Expand Down