Rename a feature inside nested MIL blocks - #2796
Open
LeSingh1 wants to merge 1 commit into
Open
Conversation
rename_feature walked only the top level of each function's block specializations. Control flow operations such as cond and while_loop hold nested blocks that reference outer vars by name, so renaming an input or output of such a model left those references behind and the result no longer parsed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rename_feature's ML Program branch walks each function'sblock_specializationsbut not the nested blocks that control flow operations hold.condandwhile_loopblocks reference outer vars by name, so renaming an input or output that they use leaves those references pointing at the old name. The renamed model then fails to load:Repro on
main:The block walk is now a recursive helper so nested blocks get the same treatment. Added a test that renames an input used by both
condbranches and checks the predictions on each branch; it fails onmainwith the error above.