Remove overhead from Logger metadata in the datapath - #72
Open
agnosticdev wants to merge 1 commit into
Open
Conversation
agnosticdev
requested review from
ekinnear,
kkuk24,
rpaulo and
tfpauly
as code owners
August 6, 2026 21:46
tfpauly
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed in our datapath functions in QUIC and IP we take a CPU hit for using the Logger object in a function, even if the code path is not being exercised.
These are typically error or fault logs and in the QUICTransfer benchmark accumulated to be over 319 megacycles:
The majority of these hits are taken when a QUICConnectionID is created or when a frame claims or unclaims.
It will drop this in the CPU trace:
This change almost completely eradicates that for QUICTransfer and brings that 319 megacycle number down to: ~ 1 megacycle
I also consistently noticed a 3 gigacycle drop in the overall CPU used over many runs, but its hard to correlate where that drop is coming from.