fix: scope apso generate formatting to generated output only (#70)#78
Merged
Conversation
The generate format step delegated to the target project's `npm run format`,
whose broad glob (e.g. `{src,test}/**/*.ts`) reformatted the entire project
tree on every run, rewriting hand-written code. Run prettier directly against
the generated output dir instead, and skip formatting when nothing was
generated.
- base-command: extract generic runCommand(command, args, silent); runNpmCommand
delegates to it.
- generate: format via `npx prettier --write <rootFolder>/autogen/**/*.ts`
(scoped to generated files; the stale src/guards glob was unnecessary since
guards live under autogen/). Guard formatting on generatedFileCount > 0 and
warn when .apsorc defines no entities.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #70
Problem
apso generate's format step delegated to the target project'snpm run format, whose broad glob (e.g.{src,test}/**/*.ts) reformatted the entire project tree on every run — rewriting hand-written code that has nothing to do with code generation.Fix
runCommand(command, args, silent);runNpmCommandnow delegates to it.npx prettier --write <rootFolder>/autogen/**/*.ts, scoped to the generated output dir (the stalesrc/guardsglob was unnecessary — guards live underautogen/). Guard formatting ongeneratedFileCount > 0, and warn when.apsorcdefines no entities.Verification
End-to-end against a throwaway project containing a deliberately mis-formatted hand-written file outside
autogen:…/src/autogen/**/*.ts; the hand-written file was byte-identical afterward (previously it would have been reformatted).🤖 Generated with Claude Code