fix: point typescript scaffold back at the v1 service template (launch blocker B4)#99
Open
cultron wants to merge 1 commit into
Open
fix: point typescript scaffold back at the v1 service template (launch blocker B4)#99cultron wants to merge 1 commit into
cultron wants to merge 1 commit into
Conversation
Published @apso/cli clones service-template-ts, whose package.json declares @apso/crud* as file:../ monorepo paths. Those packages are not on npm (E404), so a real user's scaffolded service cannot npm install, build, or deploy — the core new-user flow is broken (launch blocker B4). Revert the typescript target to the v1 service-template (published @nestjsx/crud deps, installs clean), which is also what the generators still emit imports for. The test now imports TEMPLATE_REPOS from src so any future URL drift fails CI. Switch back to service-template-ts only after @apso/crud* are published and the template's deps are converted to npm version refs (documented V2 migration). Merging to main auto-publishes via the onPushToMain workflow. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Published
@apso/cli(0.19.0) clonesservice-template-ts, whosepackage.jsondeclares@apso/crud,@apso/crud-core,@apso/crud-request,@apso/crud-typeormasfile:../monorepo paths. None of those are published to npm (verified E404 today), so a new user's scaffolded TypeScript service cannotnpm install, build, or deploy. This is launch-readiness blocker B4.What
typescripttemplate target reverted to the v1service-templaterepo (published@nestjsx/cruddeps, installs clean; matches what the generators still emit).TEMPLATE_REPOSfrom src so URL drift fails CI, with a comment documenting the three conditions for switching back (publish @apso/crud*, convert template deps to npm refs, port generators).Verification
npm run buildclean, 206/206 tests pass.service-template-tson GitHub still has thefile:refs;npm view @apso/crud→ E404 (checked 2026-07-19).Note for merger
Merging to main auto-publishes to npm (version bump + tag + publish + homebrew tarballs via
onPushToMain). Merge when you want the fixed CLI live.🤖 Generated with Claude Code