feat: aws_accounts:* commands [SC-35549] - #399
Merged
Merged
Conversation
fix a couple bugs in aws_accounts:* commands and add a couple new ones.
tvdaptible
marked this pull request as draft
November 25, 2025 09:55
tvdaptible
changed the title
UserNotFound
removed their request for review
December 4, 2025 16:31
``` make build # use ruby=2.3.1, bundler=1.17.3 to build the docker image make test # run the spec tests with ruby=2.3.1, bundler=1.17.3ruby 2.3.1 and bundler 1.17.3 make lint # run lint with ruby=2.3.1, bundler=1.17.3 make test RUBY_VERSION=2.7 # ruby=2.7, bundler=1.17.3 make test RUBY_VERSION=3.3 # ruby=3.3, bundler=<default for 3.3> ```
…to handle some dependency version gymanstics
1 task
tvdaptible
marked this pull request as ready for review
December 18, 2025 17:00
madhuravius
reviewed
Dec 18, 2025
madhuravius
left a comment
madhuravius
left a comment
Member
There was a problem hiding this comment.
documentation / clarity request, i thinke verything else here lgtm
i don't feel comfortable in shipping a require logger without either having it in docs and/or clearly marked in docker-compose so users are aware of this value. it's unlikely to collide but feels like it's sneaking in a dependency users may not be aware of
madhuravius
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix a couple bugs in aws_accounts:* commands and add a couple new ones.