StringBufferInputStream -> ByteArrayInputStream and other changes #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StringBufferInputStream doesn't convert characters properly and is deprecated. This can be an issue when parsing raw binary strings where data may be lost
|
This works for me and fixes issue #1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StringBufferInputStreamhas issues converting chars into bytes and is a deprecated classhttp://docs.oracle.com/javase/7/docs/api/java/io/StringBufferInputStream.html. This meant that parsing from strings returned wrong results (in many cases, empty content). In my case, using
FileInputStreamwasn't an option. Anything that would make use ofStringat some point would screw up the raw data.Therefore, I have replaced
StringBufferInputStreamwithByteArrayInputStreamin thejccargs.As you can see, I have reorganized the directory structure and bumped up tika to 1.1. I have also added a new module called
parserexposingfrom_fileandfrom_bufferfunctions for the lazy ones out there.Have tested the changes on Mac and Linux.