Skip to content

publish: debug locking#1569

Open
neolynx wants to merge 9 commits intomasterfrom
debug/race
Open

publish: debug locking#1569
neolynx wants to merge 9 commits intomasterfrom
debug/race

Conversation

@neolynx
Copy link
Copy Markdown
Member

@neolynx neolynx commented May 4, 2026

Fixes #

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Also, to speed up things, if you could kindly "Allow edits and access to secrets by maintainers" in the
PR settings, as this allows us to rebase the PR on master, fix conflicts, run coverage and help with
implementing code and tests.

Description of the Change

Checklist

  • allow Maintainers to edit PR (rebase, run coverage, help with tests, ...)
  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

❌ Patch coverage is 70.58824% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.23%. Comparing base (0d31298) to head (c77d788).

Files with missing lines Patch % Lines
api/publish.go 65.11% 9 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1569      +/-   ##
==========================================
- Coverage   77.23%   77.23%   -0.01%     
==========================================
  Files         161      161              
  Lines       15083    15126      +43     
==========================================
+ Hits        11649    11682      +33     
- Misses       2291     2296       +5     
- Partials     1143     1148       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

neolynx added 2 commits May 4, 2026 20:48
snapshots come in 3 kinds: local, remote and snapshot

find resources to be locked for each kind, recursively for the snapshot kind
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant