You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@svartkanin
With 7316b56, pressing enter when a username field was empty would act as a skip. Now with this change, it states The username you entered is invalid. This message seems wrong; no username was entered.
Also these type of git commit messages (Fix n) ruin the usability of git log and git show. Would you please use a description of the change as a git commit message? Using Fixes #n as a GitHub comment on the pull request is the convention.
Good point, I'll use more descriptive messages next time.
Regarding the change, yes that behaviour has changed. I don't think pressing enter should be equivalent to skip as skip is mostly used to skip the entire flow including sub selections.
So I think it makes sense to treat enter as the actual confirmation of whatever text is currently in the box even if it's empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3534