Skip to content

Fix 3534#3537

Merged
Torxed merged 1 commit intoarchlinux:masterfrom
svartkanin:fix-3534
May 29, 2025
Merged

Fix 3534#3537
Torxed merged 1 commit intoarchlinux:masterfrom
svartkanin:fix-3534

Conversation

@svartkanin
Copy link
Copy Markdown
Collaborator

Fixes #3534

@svartkanin svartkanin requested a review from Torxed as a code owner May 29, 2025 11:22
@Torxed Torxed merged commit d4b16cb into archlinux:master May 29, 2025
9 checks passed
@codefiles
Copy link
Copy Markdown
Contributor

@svartkanin
With 7316b56, pressing enter when a username field was empty would act as a skip. Now with this change, it states The username you entered is invalid. This message seems wrong; no username was entered.

Also these type of git commit messages (Fix n) ruin the usability of git log and git show. Would you please use a description of the change as a git commit message? Using Fixes #n as a GitHub comment on the pull request is the convention.

@svartkanin
Copy link
Copy Markdown
Collaborator Author

Good point, I'll use more descriptive messages next time.
Regarding the change, yes that behaviour has changed. I don't think pressing enter should be equivalent to skip as skip is mostly used to skip the entire flow including sub selections.
So I think it makes sense to treat enter as the actual confirmation of whatever text is currently in the box even if it's empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Btrfs subvolume creation fails when specifying empty subvolume name

3 participants