Skip to content

Remove underscore from _FrameDim because it's used externally #3547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svartkanin merged 1 commit into from
May 30, 2025
Merged

Remove underscore from _FrameDim because it's used externally #3547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions archinstall/tui/curses_menu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,13 @@
STYLE,
Alignment,
Chars,
FrameDim,
FrameProperties,
FrameStyle,
MenuKeys,
Orientation,
PreviewStyle,
ViewportEntry,
_FrameDim,
)


Expand Down Expand Up @@ -158,7 +158,7 @@ def align_center(self, lines: list[ViewportEntry], width: int) -> int:

def _get_right_frame(
self,
dim: _FrameDim,
dim: FrameDim,
scroll_percentage: int | None = None,
) -> list[ViewportEntry]:
right_frame = {}
Expand All @@ -181,7 +181,7 @@ def _get_right_frame(

def _get_top(
self,
dim: _FrameDim,
dim: FrameDim,
h_bar: str,
frame: FrameProperties,
scroll_percentage: int | None = None,
Expand All @@ -197,7 +197,7 @@ def _get_top(

def _get_bottom(
self,
dim: _FrameDim,
dim: FrameDim,
h_bar: str,
scroll_pct: int | None = None,
) -> ViewportEntry:
Expand All @@ -214,7 +214,7 @@ def _get_frame_dim(
max_width: int,
max_height: int,
frame: FrameProperties,
) -> _FrameDim:
) -> FrameDim:
rows = self._assemble_entries(entries).split('\n')
header_len = len(frame.header) if frame.header else 0
header_len += 3 # for header padding
Expand All @@ -237,12 +237,12 @@ def _get_frame_dim(
frame_end = max_width
frame_height = max_height - 1

return _FrameDim(frame_start, frame_end, frame_height)
return FrameDim(frame_start, frame_end, frame_height)

def _adjust_entries(
self,
entries: list[ViewportEntry],
frame_dim: _FrameDim,
frame_dim: FrameDim,
) -> list[ViewportEntry]:
for entry in entries:
# top row frame offset
Expand Down
2 changes: 1 addition & 1 deletion archinstall/tui/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ class Alignment(Enum):


@dataclass
class _FrameDim:
class FrameDim:
x_start: int
x_end: int
height: int
Expand Down