Skip to content

Use a generic instead of Any in MenuHelper #3574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svartkanin merged 1 commit into from
Jun 4, 2025
Merged

Use a generic instead of Any in MenuHelper #3574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions archinstall/lib/menu/menu_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
from typing import Any

from archinstall.lib.output import FormattedOutput
from archinstall.tui.menu_item import MenuItem, MenuItemGroup


class MenuHelper:
class MenuHelper[ValueT]:
def __init__(
self,
data: list[Any],
data: list[ValueT],
additional_options: list[str] = [],
) -> None:
self._separator = ''
Expand All @@ -30,12 +28,8 @@ def create_menu_group(self) -> MenuItemGroup:

return group

def _get_table_header(self, data_formatted: dict[str, Any]) -> list[str]:
table_header = [key for key, val in data_formatted.items() if val is None]
return table_header

def _table_to_data_mapping(self, data: list[Any]) -> dict[str, Any | None]:
display_data: dict[str, Any | None] = {}
def _table_to_data_mapping(self, data: list[ValueT]) -> dict[str, ValueT | str | None]:
display_data: dict[str, ValueT | str | None] = {}

if data:
table = FormattedOutput.as_table(data)
Expand Down