Added Compatibility to ESP32 and ESP8266 by rseidt · Pull Request #53 · arduino-libraries/ArduinoRS485

rseidt · 2024-04-03T19:21:04Z

On the ESP platform the SerialConfig enum is defined as an int32 instead of int16 as for the other platforms. So based on the idea of PR #16 from @mostafahk which seems kind of abondoned (last commit 2 years ago) I made the type dynamic.
Based on this change this will enable the ModBus Library to work on the espressifs

Co-authored-by: Robert Seidt <robert.seidt@gmail.com>

github-actions · 2024-04-03T19:26:51Z

Memory usage change @ 9692cbc

Board	flash	%	RAM for global variables	%
`arduino:mbed_portenta:envie_m7`	N/A	N/A	N/A	N/A
`arduino:samd:mkr1000`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrfox1200`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrgsm1400`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrnb1500`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrvidor4000`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrwan1300`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrwan1310`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrwifi1010`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrzero`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:mbed_opta:opta`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	`examples/RS485Passthrough` flash	%	`examples/RS485Passthrough` RAM for global variables	%	`examples/RS485Receiver` flash	%	`examples/RS485Receiver` RAM for global variables	%	`examples/RS485Sender` flash	%	`examples/RS485Sender` RAM for global variables	%
`arduino:mbed_portenta:envie_m7`	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A
`arduino:samd:mkr1000`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrfox1200`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrgsm1400`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrnb1500`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrvidor4000`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrwan1300`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrwan1310`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrwifi1010`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrzero`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:mbed_opta:opta`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0

Click for full report CSV

Board,examples/RS485Passthrough<br>flash,%,examples/RS485Passthrough<br>RAM for global variables,%,examples/RS485Receiver<br>flash,%,examples/RS485Receiver<br>RAM for global variables,%,examples/RS485Sender<br>flash,%,examples/RS485Sender<br>RAM for global variables,%
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:samd:mkr1000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrfox1200,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrgsm1400,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrnb1500,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrvidor4000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwan1310,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwifi1010,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrzero,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_opta:opta,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

jacobq · 2025-02-09T19:33:49Z

src/RS485.h

 #define SERIAL_PORT_HARDWARE Serial1
 #define RS485_DEFAULT_DE_PIN 8
 #define RS485_DEFAULT_RE_PIN 7
+#elif defined(ESP32) || defined(ESP8266)


Just curious, is this needed to fix the uint16_t issue (#16)? I assume it is intended to prevent RS485_DEFAULT_DE_PIN and RS485_DEFAULT_RE_PIN from being defined as Arduino pin names.

github-actions · 2025-09-12T22:29:14Z

Memory usage change @ baaf6dc

Board	flash	%	RAM for global variables	%
`arduino:mbed_portenta:envie_m7`	N/A	N/A	N/A	N/A
`arduino:samd:mkr1000`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrfox1200`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrgsm1400`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrnb1500`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrvidor4000`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrwan1300`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrwan1310`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrwifi1010`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrzero`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:mbed_opta:opta`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	`examples/RS485Passthrough` flash	%	`examples/RS485Passthrough` RAM for global variables	%	`examples/RS485Receiver` flash	%	`examples/RS485Receiver` RAM for global variables	%	`examples/RS485Sender` flash	%	`examples/RS485Sender` RAM for global variables	%
`arduino:mbed_portenta:envie_m7`	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A
`arduino:samd:mkr1000`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrfox1200`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrgsm1400`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrnb1500`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrvidor4000`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrwan1300`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrwan1310`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrwifi1010`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrzero`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:mbed_opta:opta`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0

Click for full report CSV

Board,examples/RS485Passthrough<br>flash,%,examples/RS485Passthrough<br>RAM for global variables,%,examples/RS485Receiver<br>flash,%,examples/RS485Receiver<br>RAM for global variables,%,examples/RS485Sender<br>flash,%,examples/RS485Sender<br>RAM for global variables,%
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:samd:mkr1000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrfox1200,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrgsm1400,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrnb1500,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrvidor4000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwan1310,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwifi1010,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrzero,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_opta:opta,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

dynamic type for serialconfig (#1)

9692cbc

Co-authored-by: Robert Seidt <robert.seidt@gmail.com>

rseidt mentioned this pull request Apr 3, 2024

invalid conversion from 'uint16_t' to 'SerialConfig' #14

Open

per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Apr 12, 2024

per1234 linked an issue Apr 12, 2024 that may be closed by this pull request

invalid conversion from 'uint16_t' to 'SerialConfig' #14

Open

jacobq reviewed Feb 9, 2025

View reviewed changes

Merge branch 'arduino-libraries:master' into master

baaf6dc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Added Compatibility to ESP32 and ESP8266#53

Added Compatibility to ESP32 and ESP8266#53
rseidt wants to merge 2 commits intoarduino-libraries:masterfrom
rseidt:master

rseidt commented Apr 3, 2024

Uh oh!

github-actions bot commented Apr 3, 2024

Uh oh!

jacobq Feb 9, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

rseidt commented Apr 3, 2024

Uh oh!

github-actions bot commented Apr 3, 2024

Uh oh!

jacobq Feb 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jacobq Feb 9, 2025 •

edited

Loading