fix: RpcCall error not private and thread safe #39

eigen-value · 2025-12-01T15:04:46Z

This PR concerns the single issue of RpcCall error state thread safety.
It introduces getters and setters for RpcCall.error fields

github-actions · 2025-12-01T15:12:54Z

Memory usage change @ 87402b9

Board	flash	%	RAM for global variables	%
`arduino:zephyr:unoq`	🔺 +1144 - +2468	+0.06 - +0.13	0 - 0	0.0 - 0.0

Click for full report table

Board	`examples/client` flash	%	`examples/client` RAM for global variables	%	`examples/clientSSL` flash	%	`examples/clientSSL` RAM for global variables	%	`examples/hci` flash	%	`examples/hci` RAM for global variables	%	`examples/monitor` flash	%	`examples/monitor` RAM for global variables	%	`examples/server` flash	%	`examples/server` RAM for global variables	%	`examples/simple_bridge` flash	%	`examples/simple_bridge` RAM for global variables	%	`examples/test` flash	%	`examples/test` RAM for global variables	%	`examples/udp_ntp_client` flash	%	`examples/udp_ntp_client` RAM for global variables	%
`arduino:zephyr:unoq`	1772	0.09	0	0.0	2036	0.1	0	0.0	1512	0.08	0	0.0	1144	0.06	0	0.0	1876	0.1	0	0.0	1444	0.07	0	0.0	1920	0.1	0	0.0	2468	0.13	0	0.0

Click for full report CSV

Board,examples/client<br>flash,%,examples/client<br>RAM for global variables,%,examples/clientSSL<br>flash,%,examples/clientSSL<br>RAM for global variables,%,examples/hci<br>flash,%,examples/hci<br>RAM for global variables,%,examples/monitor<br>flash,%,examples/monitor<br>RAM for global variables,%,examples/server<br>flash,%,examples/server<br>RAM for global variables,%,examples/simple_bridge<br>flash,%,examples/simple_bridge<br>RAM for global variables,%,examples/test<br>flash,%,examples/test<br>RAM for global variables,%,examples/udp_ntp_client<br>flash,%,examples/udp_ntp_client<br>RAM for global variables,%
arduino:zephyr:unoq,1772,0.09,0,0.0,2036,0.1,0,0.0,1512,0.08,0,0.0,1144,0.06,0,0.0,1876,0.1,0,0.0,1444,0.07,0,0.0,1920,0.1,0,0.0,2468,0.13,0,0.0

…der version

test: threading test rpc call

github-actions · 2025-12-04T16:14:02Z

Memory usage change @ 703566f

Board	flash	%	RAM for global variables	%
`arduino:zephyr:unoq`	🔺 +1148 - +2480	+0.06 - +0.13	0 - 0	0.0 - 0.0

Click for full report table

Board	`examples/client` flash	%	`examples/client` RAM for global variables	%	`examples/clientSSL` flash	%	`examples/clientSSL` RAM for global variables	%	`examples/hci` flash	%	`examples/hci` RAM for global variables	%	`examples/monitor` flash	%	`examples/monitor` RAM for global variables	%	`examples/server` flash	%	`examples/server` RAM for global variables	%	`examples/simple_bridge` flash	%	`examples/simple_bridge` RAM for global variables	%	`examples/test` flash	%	`examples/test` RAM for global variables	%	`examples/test_rpc_thread` flash	%	`examples/test_rpc_thread` RAM for global variables	%	`examples/udp_ntp_client` flash	%	`examples/udp_ntp_client` RAM for global variables	%
`arduino:zephyr:unoq`	1780	0.09	0	0.0	2044	0.1	0	0.0	1584	0.08	0	0.0	1148	0.06	0	0.0	1888	0.1	0	0.0	1468	0.07	0	0.0	1920	0.1	0	0.0	N/A	N/A	N/A	N/A	2480	0.13	0	0.0

Click for full report CSV

Board,examples/client<br>flash,%,examples/client<br>RAM for global variables,%,examples/clientSSL<br>flash,%,examples/clientSSL<br>RAM for global variables,%,examples/hci<br>flash,%,examples/hci<br>RAM for global variables,%,examples/monitor<br>flash,%,examples/monitor<br>RAM for global variables,%,examples/server<br>flash,%,examples/server<br>RAM for global variables,%,examples/simple_bridge<br>flash,%,examples/simple_bridge<br>RAM for global variables,%,examples/test<br>flash,%,examples/test<br>RAM for global variables,%,examples/test_rpc_thread<br>flash,%,examples/test_rpc_thread<br>RAM for global variables,%,examples/udp_ntp_client<br>flash,%,examples/udp_ntp_client<br>RAM for global variables,%
arduino:zephyr:unoq,1780,0.09,0,0.0,2044,0.1,0,0.0,1584,0.08,0,0.0,1148,0.06,0,0.0,1888,0.1,0,0.0,1468,0.07,0,0.0,1920,0.1,0,0.0,N/A,N/A,N/A,N/A,2480,0.13,0,0.0

github-actions · 2025-12-09T15:50:33Z

Memory usage change @ b39d418

Board	flash	%	RAM for global variables	%
`arduino:zephyr:unoq`	🔺 +1148 - +2480	+0.06 - +0.13	0 - 0	0.0 - 0.0

Click for full report table

Board	`examples/client` flash	%	`examples/client` RAM for global variables	%	`examples/clientSSL` flash	%	`examples/clientSSL` RAM for global variables	%	`examples/hci` flash	%	`examples/hci` RAM for global variables	%	`examples/monitor` flash	%	`examples/monitor` RAM for global variables	%	`examples/server` flash	%	`examples/server` RAM for global variables	%	`examples/simple_bridge` flash	%	`examples/simple_bridge` RAM for global variables	%	`examples/test` flash	%	`examples/test` RAM for global variables	%	`examples/test_rpc_thread` flash	%	`examples/test_rpc_thread` RAM for global variables	%	`examples/udp_ntp_client` flash	%	`examples/udp_ntp_client` RAM for global variables	%
`arduino:zephyr:unoq`	1780	0.09	0	0.0	2044	0.1	0	0.0	1584	0.08	0	0.0	1148	0.06	0	0.0	1888	0.1	0	0.0	1468	0.07	0	0.0	1920	0.1	0	0.0	N/A	N/A	N/A	N/A	2480	0.13	0	0.0

Click for full report CSV

Board,examples/client<br>flash,%,examples/client<br>RAM for global variables,%,examples/clientSSL<br>flash,%,examples/clientSSL<br>RAM for global variables,%,examples/hci<br>flash,%,examples/hci<br>RAM for global variables,%,examples/monitor<br>flash,%,examples/monitor<br>RAM for global variables,%,examples/server<br>flash,%,examples/server<br>RAM for global variables,%,examples/simple_bridge<br>flash,%,examples/simple_bridge<br>RAM for global variables,%,examples/test<br>flash,%,examples/test<br>RAM for global variables,%,examples/test_rpc_thread<br>flash,%,examples/test_rpc_thread<br>RAM for global variables,%,examples/udp_ntp_client<br>flash,%,examples/udp_ntp_client<br>RAM for global variables,%
arduino:zephyr:unoq,1780,0.09,0,0.0,2044,0.1,0,0.0,1584,0.08,0,0.0,1148,0.06,0,0.0,1888,0.1,0,0.0,1468,0.07,0,0.0,1920,0.1,0,0.0,N/A,N/A,N/A,N/A,2480,0.13,0,0.0

Tcp improvements

github-actions · 2025-12-15T09:51:23Z

Memory usage change @ 15def13

Board	flash	%	RAM for global variables	%
`arduino:zephyr:unoq`	🔺 +1148 - +2964	+0.06 - +0.15	0 - 0	0.0 - 0.0

Click for full report table

Board	`examples/client` flash	%	`examples/client` RAM for global variables	%	`examples/clientSSL` flash	%	`examples/clientSSL` RAM for global variables	%	`examples/hci` flash	%	`examples/hci` RAM for global variables	%	`examples/monitor` flash	%	`examples/monitor` RAM for global variables	%	`examples/server` flash	%	`examples/server` RAM for global variables	%	`examples/simple_bridge` flash	%	`examples/simple_bridge` RAM for global variables	%	`examples/test` flash	%	`examples/test` RAM for global variables	%	`examples/test_rpc_thread` flash	%	`examples/test_rpc_thread` RAM for global variables	%	`examples/udp_ntp_client` flash	%	`examples/udp_ntp_client` RAM for global variables	%
`arduino:zephyr:unoq`	2700	0.14	0	0.0	2964	0.15	0	0.0	1584	0.08	0	0.0	1148	0.06	0	0.0	2808	0.14	0	0.0	1468	0.07	0	0.0	1920	0.1	0	0.0	N/A	N/A	N/A	N/A	2480	0.13	0	0.0

Click for full report CSV

Board,examples/client<br>flash,%,examples/client<br>RAM for global variables,%,examples/clientSSL<br>flash,%,examples/clientSSL<br>RAM for global variables,%,examples/hci<br>flash,%,examples/hci<br>RAM for global variables,%,examples/monitor<br>flash,%,examples/monitor<br>RAM for global variables,%,examples/server<br>flash,%,examples/server<br>RAM for global variables,%,examples/simple_bridge<br>flash,%,examples/simple_bridge<br>RAM for global variables,%,examples/test<br>flash,%,examples/test<br>RAM for global variables,%,examples/test_rpc_thread<br>flash,%,examples/test_rpc_thread<br>RAM for global variables,%,examples/udp_ntp_client<br>flash,%,examples/udp_ntp_client<br>RAM for global variables,%
arduino:zephyr:unoq,2700,0.14,0,0.0,2964,0.15,0,0.0,1584,0.08,0,0.0,1148,0.06,0,0.0,2808,0.14,0,0.0,1468,0.07,0,0.0,1920,0.1,0,0.0,N/A,N/A,N/A,N/A,2480,0.13,0,0.0

Bridge getRouterVersion & Monitor compatibility mode

github-actions · 2025-12-15T10:01:30Z

Memory usage change @ 91fdc9d

Board	flash	%	RAM for global variables	%
`arduino:zephyr:unoq`	🔺 +1612 - +3472	+0.08 - +0.18	🔺 +8 - +8	0.0 - 0.0

Click for full report table

Board	`examples/client` flash	%	`examples/client` RAM for global variables	%	`examples/clientSSL` flash	%	`examples/clientSSL` RAM for global variables	%	`examples/hci` flash	%	`examples/hci` RAM for global variables	%	`examples/monitor` flash	%	`examples/monitor` RAM for global variables	%	`examples/server` flash	%	`examples/server` RAM for global variables	%	`examples/simple_bridge` flash	%	`examples/simple_bridge` RAM for global variables	%	`examples/test` flash	%	`examples/test` RAM for global variables	%	`examples/test_rpc_thread` flash	%	`examples/test_rpc_thread` RAM for global variables	%	`examples/udp_ntp_client` flash	%	`examples/udp_ntp_client` RAM for global variables	%
`arduino:zephyr:unoq`	3200	0.16	8	0.0	3472	0.18	8	0.0	1716	0.09	8	0.0	1996	0.1	8	0.0	3316	0.17	8	0.0	1612	0.08	8	0.0	2764	0.14	8	0.0	N/A	N/A	N/A	N/A	2960	0.15	8	0.0

Click for full report CSV

Board,examples/client<br>flash,%,examples/client<br>RAM for global variables,%,examples/clientSSL<br>flash,%,examples/clientSSL<br>RAM for global variables,%,examples/hci<br>flash,%,examples/hci<br>RAM for global variables,%,examples/monitor<br>flash,%,examples/monitor<br>RAM for global variables,%,examples/server<br>flash,%,examples/server<br>RAM for global variables,%,examples/simple_bridge<br>flash,%,examples/simple_bridge<br>RAM for global variables,%,examples/test<br>flash,%,examples/test<br>RAM for global variables,%,examples/test_rpc_thread<br>flash,%,examples/test_rpc_thread<br>RAM for global variables,%,examples/udp_ntp_client<br>flash,%,examples/udp_ntp_client<br>RAM for global variables,%
arduino:zephyr:unoq,3200,0.16,8,0.0,3472,0.18,8,0.0,1716,0.09,8,0.0,1996,0.1,8,0.0,3316,0.17,8,0.0,1612,0.08,8,0.0,2764,0.14,8,0.0,N/A,N/A,N/A,N/A,2960,0.15,8,0.0

pennam · 2025-12-15T13:29:15Z

@eigen-value Tested HCI commands using ArduinoBLE and UNO Q 💚

fix: RpcCall error not private and thread safe

87402b9

eigen-value requested a review from pennam December 1, 2025 15:04

eigen-value added 3 commits December 1, 2025 18:07

impr: handling TCP read timeout and error

3d76eee

mod: Monitor compatibility uses Bridge->call to write if router is ol…

6bbdefc

…der version

impr: thread safety of bridge, monitor and hci

703566f

test: threading test rpc call

eigen-value requested review from iabdalkader and pennam and removed request for pennam December 4, 2025 16:07

test: threading test rpc call with thread join

b39d418

Merge pull request #41 from arduino-libraries/tcp_improvements

15def13

Tcp improvements

pennam approved these changes Dec 15, 2025

View reviewed changes

Merge pull request #42 from arduino-libraries/monitor_compat_mode

91fdc9d

Bridge getRouterVersion & Monitor compatibility mode

eigen-value merged commit 9f5f598 into main Dec 15, 2025
5 checks passed

eigen-value deleted the rpccall_thread_safety branch December 15, 2025 13:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: RpcCall error not private and thread safe #39

fix: RpcCall error not private and thread safe #39

Uh oh!

eigen-value commented Dec 1, 2025

Uh oh!

github-actions bot commented Dec 1, 2025

Uh oh!

github-actions bot commented Dec 4, 2025

Uh oh!

github-actions bot commented Dec 9, 2025

Uh oh!

github-actions bot commented Dec 15, 2025

Uh oh!

github-actions bot commented Dec 15, 2025

Uh oh!

pennam commented Dec 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix: RpcCall error not private and thread safe #39

fix: RpcCall error not private and thread safe #39

Uh oh!

Conversation

eigen-value commented Dec 1, 2025

Uh oh!

github-actions bot commented Dec 1, 2025

Uh oh!

github-actions bot commented Dec 4, 2025

Uh oh!

github-actions bot commented Dec 9, 2025

Uh oh!

github-actions bot commented Dec 15, 2025

Uh oh!

github-actions bot commented Dec 15, 2025

Uh oh!

pennam commented Dec 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants