misc: extend flash and memory usage optimizations to other variants #292
Conversation
pennam
force-pushed
the
disable-shell-v3
branch
from
0517870 to
5c15ce2
Compare
pennam
changed the title
pennam
force-pushed
the
disable-shell-v3
branch
2 times, most recently
from
8dc70b5 to
654f55f
Compare
|
build test reports https://github.com/pillo79/ArduinoCore-zephyr/actions/runs/20278816334 |
|
GIGA R1 Tests |
|
Portenta H7 Tests |
| CONFIG_THREAD_STACK_INFO=y | ||
| CONFIG_DYNAMIC_THREAD=y | ||
| CONFIG_DYNAMIC_THREAD_ALLOC=y |
There was a problem hiding this comment.
they were y selected by SHELL, and are needed to make k_thread_stack_alloc and friends to work.
There was a problem hiding this comment.
They're not selected by the shell, and if you build main those options were Not set for Portenta H7, Giga etc..
|
|
||
| CONFIG_LLEXT_STORAGE_WRITABLE=n | ||
| CONFIG_SHELL_STACK_SIZE=1024 | ||
| CONFIG_HEAP_MEM_POOL_SIZE=1024 |
There was a problem hiding this comment.
1K heap seems too small, even the stack is 2K. Maybe consider increasing this?
| #CONFIG_LOG_PROCESS_THREAD_STACK_SIZE=8192 | ||
| #CONFIG_IDLE_STACK_SIZE=8192 |
There was a problem hiding this comment.
I'd remove these commented options.
In DEBUG mode if SHELL is disabled and board has a logging uart, loader will use it to print logs
uart will be used by loader for logging when SHELL is not enabled
uart will be used by loader for logging when SHELL is not enabled
uart will be used by loader for logging when SHELL is not enabled
uart will be used by loader for logging when SHELL is not enabled
uart will be used by loader for logging when SHELL is not enabled
pennam
force-pushed
the
disable-shell-v3
branch
from
654f55f to
1dab3fb
Compare
log_backend_init already initializes usb cdc_acm peripheral
2 participants
OPTAandGIGAandPORTENTA H7SHELLfor all variantsCPPfor all variantscdc_acmperpheral to be used from the loader to print logs if shell is disabled and debug enabledOPTAGIGAPORTENTA H7PORTENTA C33NANO 33 BLEDYNAMIC_THREADis enabled for all boards if not explicitly disabled in the variant (NANO MATTER)Boards to be checked before disabling SHELL for all variants and CPP