[API] Add stop upgrade endpoint #71
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giulio93
reviewed
Nov 14, 2025
giulio93
reviewed
Nov 14, 2025
| return func(yield func(string, error) bool) { | ||
| outputWriter := orchestrator.NewCallbackWriter(func(line string) { | ||
| if !yield(line, nil) { | ||
| err := cmd.Kill() |
Contributor
There was a problem hiding this comment.
Do we need a force kill here?
Contributor
Author
There was a problem hiding this comment.
Yes, after conducting some tests, we observed that runWithContext wasn't triggering the kill, so we decided to explicitly implement it
Contributor
|
@mirkoCrobu can you fix the conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
closes https://github.com/bcmi-labs/orchestrator/issues/382
Change description
Adding API endpoint
PUT /v1/system/update/stop.It stops service and platform updates.
The update cancellation is implemented via a SIGTERM signal (context cancellation) to allow for a graceful shutdown.
apt-get, In some phases, traps this signal to complete its current critical operation before exiting, delaying the interruption.Additional Notes
Test
curl -X GET localhost:8800/v1/system/update/eventscurl -X PUT localhost:8800/v1/system/update/applycurl -X PUT localhost:8800/v1/system/update/stopReviewer checklist
main.