Stream2 fix #80
Open
Stream2 fix #80
+187
−158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and the Stream2 interface is used. Previously 3-D NDArrays were created, with the third dimension being the threshold index. This does not work when the driver does not decompress the data, because the arrays are individually compressed but a 3-D array must be compressed as a unit. The driver now only creates 2-D NDArrays, and creates new NDAttributes, ThresholdName and ThresholdEnergy to identify which threshold an NDArray contains. The driver sends all thresholds on asyn address 0, and threshold N on asyn address N (N=1 to number of enabled thresholds).
Collaborator
|
Small but important detail: addr 1 is already in use by the Monitor interface in the current driver (see eigerDetector.cpp:L1849 — ADEiger/eigerApp/src/eigerDetector.cpp Line 1849 in b586e87 Reusing it for threshold callbacks would collide with existing monitor consumers. We probably need to keep addr 1 reserved and offset the threshold addresses, or move the monitor stream elsewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements code changes described in #79