Skip to content

Stabilize Cloudflare SSR dependency optimization - #11

Merged
andycamara merged 1 commit into
mainfrom
fix/cloudflare-ssr-optimizer
Aug 2, 2026
Merged

andycamara merged 1 commit into
mainfrom
fix/cloudflare-ssr-optimizer

Conversation

@andycamara

@andycamara andycamara commented Jul 30, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Pre-optimize fast-xml-parser in top-level and Cloudflare SSR environments.
  • Exclude @unocss/preset-typography from the disposable SSR optimizer graph.
  • Keep outdated-request handling enabled for the Cloudflare environment.

Root cause

Late dependency discovery replaced deps_ssr while workerd still referenced a prior generated route-cache chunk.

Impact

Public SSR no longer loses the generated route-cache module after admin initialization triggers optimizer work.

Validation

  • Production Cloudflare build passed.
  • Public SSR returned identical successful output before and after following the admin setup route.
  • No late optimization or missing route-cache error was observed.
  • The combined v0.5.10 series passed 4,842 tests with 1 skipped, plus check, runtime smoke, and package smoke.

Release plan

Part 7 of 9 for v0.5.10.

Summary by CodeRabbit

  • Bug Fixes
    • Improved server-side rendering compatibility and dependency handling.
    • Preserved environment-specific styling behavior while optimizing server-rendered pages.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b1a3b7b2-c954-419c-8f8c-9c5eee3c37e2

📥 Commits

Reviewing files that changed from the base of the PR and between b5a73b0 and 08157e3.

📒 Files selected for processing (1)
  • astro.config.ts

📝 Walkthrough

Walkthrough

The Astro configuration adds SSR dependency optimization lists. It excludes @unocss/preset-typography, includes fast-xml-parser, and applies these lists to SSR and top-level optimizer settings while preserving runtime-specific UnoCSS filtering.

Changes

SSR dependency optimization

Layer / File(s) Summary
Optimizer lists and wiring
astro.config.ts
The configuration defines SSR exclusion and inclusion lists, applies them to the SSR optimizer, and extends SSR and top-level optimizer settings. Existing Node and Cloudflare UnoCSS filtering remains in place.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the change and validation, but it omits the required Checklist, Architecture, Security Notes, and Screenshots sections. Add all required template sections and mark each applicable checklist item; state whether security-sensitive areas were touched and provide screenshots or explain why they do not apply.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: stabilizing Cloudflare SSR dependency optimization.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/cloudflare-ssr-optimizer

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@andycamara
andycamara marked this pull request as ready for review July 30, 2026 15:34
@andycamara
andycamara force-pushed the fix/cloudflare-ssr-optimizer branch from f049937 to 08157e3 Compare August 2, 2026 18:13
@andycamara
andycamara merged commit 2c62011 into main Aug 2, 2026
4 checks passed
@andycamara
andycamara deleted the fix/cloudflare-ssr-optimizer branch August 2, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant