Skip to content

Fix public icon rendering - #13

Merged
andycamara merged 1 commit into
mainfrom
fix/public-icon-rendering
Aug 2, 2026
Merged

andycamara merged 1 commit into
mainfrom
fix/public-icon-rendering

Conversation

@andycamara

Copy link
Copy Markdown
Contributor

Summary

  • Pass runtime asset bindings into public and 404 page rendering.
  • Inline canonical Lucide SVG assets consistently.
  • Generate responsive icon selectors against the rendered SVG element.
  • Keep utility classes off the Stage icon host during live updates.
  • Use a Lucide placeholder in the Inspector.

Root cause

Public routes did not pass runtime asset bindings into the renderer, and generated icon styles targeted the pre-hydration host element instead of canonical inline SVG output.

Impact

Icons render consistently across public pages, 404 pages, initial Stage output, and live Inspector updates.

Validation

  • Public rendering, node stylesheet, Stage live-update, and Inspector tests passed: 66 tests.
  • The combined v0.5.10 series passed 4,842 tests with 1 skipped, plus check, production build, runtime smoke, and package smoke.

Release plan

Part 9 of 9 for v0.5.10. The release/version PR follows after all nine changes merge.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@andycamara, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 32 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f8ec3f25-0a9d-4a26-9836-17c81aec1358

📥 Commits

Reviewing files that changed from the base of the PR and between b71047b and cc123d5.

📒 Files selected for processing (7)
  • aria/admin/features/Stage/composables/useStageLiveCanvasUpdates.ts
  • aria/lib/blocks/nodesToHtml.ts
  • aria/tests/features/stage/useStageLiveCanvasUpdates.test.ts
  • aria/tests/lib/nodesToHtml.test.ts
  • aria/tests/lib/rendering/renderPageDslToHtml.test.ts
  • src/pages/404.astro
  • src/pages/[...slug].astro

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@andycamara
andycamara marked this pull request as ready for review July 30, 2026 15:34
@andycamara
andycamara force-pushed the fix/public-icon-rendering branch from 25f4959 to cc123d5 Compare August 2, 2026 18:40
@andycamara
andycamara merged commit 86fb355 into main Aug 2, 2026
5 of 7 checks passed
@andycamara
andycamara deleted the fix/public-icon-rendering branch August 2, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant