Skip to content

Resolve canonical render surfaces - #17

Merged
andycamara merged 1 commit into
mainfrom
feature/render-v2-resolved-surfaces
Aug 2, 2026
Merged

andycamara merged 1 commit into
mainfrom
feature/render-v2-resolved-surfaces

Conversation

@andycamara

Copy link
Copy Markdown
Contributor

Summary

  • port the Phase 4 resolved-surface graph for pages, layouts, components, CMS inputs, and render dependencies
  • route Stage, public rendering, snapshots, exports, and stylesheet inputs through the canonical resolved contract
  • add the explicit-any and suppression type-safety ratchet, including the InputOtp container-class correction
  • reconcile the remaining port drift so this branch is tree-identical to aria-demo Phase 4

Validation

  • type-safety boundary: 3,316 TypeScript surfaces with no explicit any or suppression directives
  • rendering foundation: 38 passed, 5 expected parity failures in Node; 37 passed in workerd
  • runtime stability: 3 passed in workerd
  • canvas parity: 18 passed across Node and workerd
  • rendering writer, portability, and route-isolation checks passed
  • Astro check: 0 errors
  • tree object matches aria-demo Phase 4: 508f958ecb38fee6a1218f8ac768f8b1b20b8145

No release, tag, deployment, or database migration execution is included.

@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Too many files!

This PR contains 110 files, which is 10 over the limit of 100.

To get a review, narrow the scope:
• coderabbit review --committed # exclude uncommitted changes
• coderabbit review --dir # limit to a subdirectory
• coderabbit review --base # compare against a closer base

Upgrade to a paid plan to raise the limit.

This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3ddccd30-18d0-4887-b2b1-9ef9043737fb

📥 Commits

Reviewing files that changed from the base of the PR and between 1357fdb and d01601c.

📒 Files selected for processing (110)
  • .github/workflows/ci.yml
  • aria/actions/content-sync.ts
  • aria/admin/components/ui/input-otp/InputOtp.vue
  • aria/admin/components/ui/resizable/ResizableHandle.vue
  • aria/admin/components/ui/resizable/ResizablePanel.vue
  • aria/admin/components/ui/resizable/ResizablePanelGroup.vue
  • aria/admin/features/Agent/lib/sessionHistory.ts
  • aria/admin/features/Agent/lib/tools/classes/writeTools.ts
  • aria/admin/features/Agent/server/AriaStudioAgent.ts
  • aria/admin/features/Blocks/elements/BaseElement.vue
  • aria/admin/features/Design/composables/useClassManagerTable.ts
  • aria/admin/features/Design/composables/useCustomBreakpointsTable.ts
  • aria/admin/features/Design/composables/useGlobalStyles.ts
  • aria/admin/features/Design/composables/useVariableManagerTable.ts
  • aria/admin/features/Design/lib/designImporter.ts
  • aria/admin/features/Stage/composables/useStageLiveCanvasUpdates.ts
  • aria/admin/features/Studio/layouts/components/LayoutLocalizationPanel.vue
  • aria/admin/features/Studio/pages/components/detail/PageDetailLocalizationTab.vue
  • aria/admin/features/Studio/pages/composables/usePagesTable.ts
  • aria/admin/main.ts
  • aria/lib/blocks/componentReference.ts
  • aria/lib/blocks/nodeUtils.ts
  • aria/lib/cms/resolveBoundNodes.ts
  • aria/lib/export/storage.ts
  • aria/lib/layouts/canvasSlotMerge.ts
  • aria/lib/rendering/PageRenderer.astro
  • aria/lib/rendering/canonical/contract.ts
  • aria/lib/rendering/canonical/index.ts
  • aria/lib/rendering/canonical/resolveLayoutSlots.ts
  • aria/lib/rendering/canonical/resolveRenderSurface.ts
  • aria/lib/rendering/renderPageDslToHtml.ts
  • aria/lib/rendering/storageRenderDependencyProvider.ts
  • aria/lib/schemas/nodes.ts
  • aria/lib/schemas/storage.ts
  • aria/lib/storage/cloudflare.ts
  • aria/lib/storage/cloudflarePlatform.ts
  • aria/lib/storage/d1-database-types.ts
  • aria/lib/storage/d1-http-database.ts
  • aria/lib/storage/internal/domains/contextTypes.ts
  • aria/lib/storage/internal/domains/dslAssets.ts
  • aria/lib/storage/internal/domains/pageAccess.ts
  • aria/lib/storage/internal/domains/pageLifecycle.ts
  • aria/lib/storage/internal/domains/pageReads.ts
  • aria/lib/storage/sqlitePlatform.ts
  • aria/scripts/check-type-safety.ts
  • aria/scripts/push-remote-content.ts
  • aria/scripts/verify-localization-schema.ts
  • aria/tests/actions/auth-preferences.test.ts
  • aria/tests/actions/library-pack-version.test.ts
  • aria/tests/actions/media-upload.test.ts
  • aria/tests/actions/save-action-nonce.test.ts
  • aria/tests/blocks/BlockLibrary.runtime.test.ts
  • aria/tests/composables/useGlobalStyles.test.ts
  • aria/tests/composables/usePropertySavePreview.test.ts
  • aria/tests/composables/useSignals.test.ts
  • aria/tests/content-sync/actions.test.ts
  • aria/tests/content-sync/default-planner.test.ts
  • aria/tests/content-sync/executor.test.ts
  • aria/tests/content-sync/repository.test.ts
  • aria/tests/core/requestLocals.test.ts
  • aria/tests/core/useAppRouter.test.ts
  • aria/tests/export/site-export.test.ts
  • aria/tests/features/agent/mcp-token-activation.test.ts
  • aria/tests/features/agent/speech-dictation.test.ts
  • aria/tests/features/agent/tools/list-pages-integration.test.ts
  • aria/tests/features/cms/StructuredTextEditor.test.ts
  • aria/tests/features/design/useClassManagerInventory.test.ts
  • aria/tests/features/inspector/inspector-design-cms-binding.test.ts
  • aria/tests/features/stage/StageMarkupPreviewPanel.test.ts
  • aria/tests/features/stage/useStageLiveCanvasUpdates.test.ts
  • aria/tests/features/studio/page-inventory-action.test.ts
  • aria/tests/helpers/actionHandler.ts
  • aria/tests/helpers/builderNodeFixture.ts
  • aria/tests/icons/action-handlers.integration.test.ts
  • aria/tests/inputs/BackgroundProperty.test.ts
  • aria/tests/inputs/BorderProperty.test.ts
  • aria/tests/inputs/ButtonProperty.test.ts
  • aria/tests/inputs/DesignTab.test.ts
  • aria/tests/inputs/DisplayProperty.test.ts
  • aria/tests/inputs/IconListProperty.test.ts
  • aria/tests/inputs/IconProperty.test.ts
  • aria/tests/inputs/ImageProperty.previewPicker.test.ts
  • aria/tests/inputs/ImageProperty.test.ts
  • aria/tests/inputs/LinkProperty.test.ts
  • aria/tests/inputs/ListProperty.test.ts
  • aria/tests/inputs/ShadowProperty.test.ts
  • aria/tests/inputs/TransformProperty.test.ts
  • aria/tests/inputs/TypographyProperty.test.ts
  • aria/tests/inputs/VisibilityProperty.test.ts
  • aria/tests/integration/page-lifecycle.test.ts
  • aria/tests/integration/publishing-snapshot-injection.test.ts
  • aria/tests/lib/layouts/canvasSlotMerge.test.ts
  • aria/tests/lib/rendering/renderPageDslToHtml.test.ts
  • aria/tests/lib/rendering/storageRenderDependencyProvider.test.ts
  • aria/tests/media/cloudflare-storage-adapter.test.ts
  • aria/tests/rendering-foundation/foundation-gaps.node.test.ts
  • aria/tests/rendering-foundation/resolved-surface.parity.test.ts
  • aria/tests/scripts/check-type-safety.test.ts
  • aria/tests/setup.ts
  • aria/tests/storage/authorship-persistence.test.ts
  • aria/tests/storage/cloudflare-storage.test.ts
  • aria/tests/storage/editorial-workflow-adapter-parity.test.ts
  • aria/tests/storage/public-comments-adapter-parity.test.ts
  • aria/tests/storage/site-localization-adapter-parity.test.ts
  • aria/tests/storage/site-localization-baseline.test.ts
  • package.json
  • src/pages/404.astro
  • src/pages/[...slug].astro
  • vitest.rendering-foundation.node.config.ts
  • vitest.rendering-foundation.workerd.config.ts

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@andycamara
andycamara merged commit b87e5dc into main Aug 2, 2026
4 checks passed
@andycamara
andycamara deleted the feature/render-v2-resolved-surfaces branch August 2, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant