Skip to content

Remove deprecated argument from IonicAudioModule.forRoot in demo #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lujakob wants to merge 2 commits into
base: 2.0
Choose a base branch
from
Open

Remove deprecated argument from IonicAudioModule.forRoot in demo #99

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07cc5ff
Remove module forRoot deprecated argument in demo.
lujakob Feb 27, 2017
222c4ed
Remove deprecated import audioProviderFactory.
lujakob Feb 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions demo/src/app/app.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { ContactPage } from '../pages/contact/contact';
import { HomePage } from '../pages/home/home';
import { TabsPage } from '../pages/tabs/tabs';

import { IonicAudioModule, AudioProvider, WebAudioProvider, audioProviderFactory } from 'ionic-audio/dist';
import { IonicAudioModule, AudioProvider, WebAudioProvider } from 'ionic-audio/dist';

/**
* Sample custom factory function to use with ionic-audio
Expand All @@ -25,9 +25,8 @@ export function myCustomAudioProviderFactory() {
],
imports: [
IonicModule.forRoot(MyApp),
IonicAudioModule.forRoot({ provide: AudioProvider, useFactory: audioProviderFactory }),
// or use custom function above to force a specific provider
// { provide: AudioProvider, useFactory: myCustomAudioProviderFactory }
IonicAudioModule.forRoot(),
// or use custom function above as forRoot argument to force a specific provider
],
bootstrap: [IonicApp],
entryComponents: [
Expand Down