Skip to content

Bounds-check unchecked input reads in fastlz1/fastlz2_decompress (OOB read) #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eobi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bounds-check unchecked input reads in fastlz1/fastlz2_decompress (OOB read) #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions fastlz.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,7 @@ static int fastlz1_decompress(const void* input, int length, void* output, int m
FASTLZ_BOUND_CHECK(ip <= ip_bound);
len += *ip++;
}
FASTLZ_BOUND_CHECK(ip <= ip_bound);
ref -= *ip++;
len += 3;
FASTLZ_BOUND_CHECK(op + len <= op_limit);
Expand Down Expand Up @@ -446,6 +447,7 @@ static int fastlz2_decompress(const void* input, int length, void* output, int m
code = *ip++;
len += code;
} while (code == 255);
FASTLZ_BOUND_CHECK(ip <= ip_bound);
code = *ip++;
ref -= code;
len += 3;
Expand Down Expand Up @@ -488,6 +490,7 @@ int fastlz_compress(const void* input, int length, void* output) {
}

int fastlz_decompress(const void* input, int length, void* output, int maxout) {
if (length < 1) return 0;
/* magic identifier for compression level */
int level = ((*(const uint8_t*)input) >> 5) + 1;

Expand Down