Offer explicit recovery choices during setup - #109
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Required live conversation and persistence validation remains incomplete in both affected parent harnesses.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds explicit setup choices for fallback recovery and same-route continuation while preserving existing policies until confirmed.
Changes:
- Adds three fallback modes and independent continuation configuration.
- Adds verification scenarios for setup and persistence.
- Bumps the package candidate to 1.10.3 with changelog updates.
| File | Description |
|---|---|
UPSTREAM.md |
Records version 1.10.3. |
CHANGELOG.md |
Documents the candidate release. |
.claude-plugin/marketplace.json |
Updates marketplace version. |
plugins/pstack/.claude-plugin/plugin.json |
Updates Claude plugin version. |
plugins/pstack/.codex-plugin/plugin.json |
Updates Codex plugin version. |
plugins/pstack/skills/setup-pstack/SKILL.md |
Defines recovery and continuation choices. |
plugins/pstack/skills/poteto-mode/references/provider-dispatch.md |
Documents empty fallback semantics. |
tests/setup-selected-providers.md |
Adds behavioral verification cases. |
.agents/skills/verify-open-pstack/features/setup.md |
Adds installed-parent verification coverage. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
arjitj2
marked this pull request as ready for review
October 1, 2026 19:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #108.
What changed
Setup now offers automatic backend recovery, usage exhaustion only, or no automatic fallback on first setup and reruns. It asks separately about bounded same-model continuation, reuses explicit answers, preserves custom policies until accepted, and shows both settings before saving. Disabling fallback saves an empty trigger list; disabling continuation removes its separate declaration.
The existing policy engine is unchanged. The package candidate is 1.10.3. Verification recipes cover the new conversation and persistence cases.
Verification
Live evidence:
21586358e02bf2a657409e3a39d827ca18cda8fa; packaged treeb514175f6a3250b765693041d18f543104808cfb./pstack:setup-pstackagainst disposable native-only targets. Observed the real Skill invocation, inherited native marker probe, all three fallback modes, an independent continuation question, a two-total-execution explanation, and unchanged targets before confirmation. Seven live turns covered broad, quota-only and disabled fallback; independent continuation opt-in and removal; byte-identical custom-policy preservation; first-run recommendation and target absence before confirmation; and confirmed first-run save/readback. Five save/keep runs each passed a native marker probe, a smoke candidate, and a separate native reviewer. The final saved sheets and integration files were independently read back; each retained the requested settings. All aliases use the parent, so no external provider was probed.setup-recovery-108marketplace: ran the actual installed setup skill usinggpt-6.1-solat high effort. Live conversations covered all three fallback modes; independent continuation opt-in and removal; exact custom-policy preservation; and first-run choices with both targets absent before confirmation. Five save/keep flows passed actual inherited native marker probes, policy-artifact workers and distinct native reviewers. Independently checked saved sheet/integration bytes. Host session transcripts retain the actual native launch and completion events, with model and effort overrides omitted for inherited lanes.libsimdjson.29.dylib; all 765 tests passed after selecting the bundled Node runtime. Strict typecheck also passed using Bun's Node compatibility launcher.Evidence is retained outside the checkout at
/Users/arjitjaiswal/open-pstack-verification-setup-recovery/. The real policy CLI additionally passed 48 decisions against explicitly synthetic outcomes across four modes and two parents. These inputs do not establish real provider failure or continuation; the runtime engine is unchanged.Copilot’s one finding was corrected in
a86941b: the new behavioral cases are 16 and 17, and the feature recipe matches. The reply is published, the thread is resolved, and there are no pending owner reviews. GitHubverifypasses on the final head.Cleanup removed only the temporary Codex candidate installation and archived the validation parent sessions. Claude used a session-local plugin directory. The personal 1.10.2 installation was not replaced.
Documentation impact
The owning setup skill and provider-dispatch reference describe the choices and disabled-policy semantics. The model-setup verification recipe and behavioral cases cover reproducible validation. Version mirrors and changelog identify candidate 1.10.3.