Fix WIP effect types Constant, Ramp, and Condition#1
Open
google-labs-jules[bot] wants to merge 1 commit intomasterfrom
Open
Fix WIP effect types Constant, Ramp, and Condition#1google-labs-jules[bot] wants to merge 1 commit intomasterfrom
google-labs-jules[bot] wants to merge 1 commit intomasterfrom
Conversation
* Added `level`, `start_strength`, and `end_strength` to `FFDEffect`. * Populated the missing fields in `ffb.cpp` for Constant and Ramp effects. * Fixed the Condition effect by unconditionally writing to axes indices. * Addressed `switch` statement fallthroughs in `ffb.cpp`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where most Force Feedback effects (Constant, Ramp, Condition) did not work because their parameters were not being correctly passed down to the SDL structures.
Fixes DMJC#3
PR created automatically by Jules for task 15145853833366608939 started by @arran4